Conversation
📝 WalkthroughWalkthroughVersion 2.1.2 release preparation: Updates version metadata across library.json, library.properties, and HttpCommon.h from 2.1.1 to 2.1.2, adds CHANGELOG.md with release history, and removes CHANGELOG.md from .gitignore to track it in the repository. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Pull request overview
Prepares the repository for the 2.1.2 release by synchronizing version metadata across distribution files and adding a changelog to document releases.
Changes:
- Bumped project version to
2.1.2acrosssrc/HttpCommon.h,library.properties, andlibrary.json. - Reformatted
library.jsonarray fields for consistent formatting. - Added
CHANGELOG.mdand ensured it is tracked by git (removed from.gitignore).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/HttpCommon.h |
Updates in-code version macro to 2.1.2. |
library.properties |
Updates Arduino library version to 2.1.2. |
library.json |
Updates PlatformIO/library version to 2.1.2 and normalizes array formatting. |
CHANGELOG.md |
Introduces a changelog documenting release history and the new 2.1.2 entry. |
.gitignore |
Stops ignoring CHANGELOG.md so it can be committed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "ESPAsyncWebClient", | ||
| "version": "2.1.1", | ||
| "version": "2.1.2", | ||
| "description": "Asynchronous HTTP client library for ESP32 ", |
There was a problem hiding this comment.
The PR title ("Correct auto tag functionality") doesn’t match the actual changes here (version/metadata bump + formatting). This makes the intent of the release harder to track in history and automation; please align the title and/or PR description to reflect the version sync + changelog addition (or add the missing functional changes if they were intended).
There was a problem hiding this comment.
🧹 Nitpick comments (1)
CHANGELOG.md (1)
15-17: Consider reducing repeated bullet starters for readability.Several consecutive bullets start with identical prefixes (
**Fix**/**Breaking**). Optional wording variation would make scanning easier.Also applies to: 27-28
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CHANGELOG.md` around lines 15 - 17, The CHANGELOG contains several consecutive bullets starting with identical starters like `**Fix**` and `**Breaking**`, making it harder to scan; update the bullets (the lines containing the `**Fix**`/`**Breaking**` markers) to reduce repetition by varying the starter wording (e.g., alternate with "Fixes", "Bugfix", "Changed", or merge related fixes under a single `**Fix**` entry) or group related items into a single bullet with sub-items, ensuring the existing entries about `Content-Length` parsing, `Transfer-Encoding` multi-value support, and `setMaxBodySize()` enforcement remain unchanged in content but are reformatted for readability.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@CHANGELOG.md`:
- Around line 15-17: The CHANGELOG contains several consecutive bullets starting
with identical starters like `**Fix**` and `**Breaking**`, making it harder to
scan; update the bullets (the lines containing the `**Fix**`/`**Breaking**`
markers) to reduce repetition by varying the starter wording (e.g., alternate
with "Fixes", "Bugfix", "Changed", or merge related fixes under a single
`**Fix**` entry) or group related items into a single bullet with sub-items,
ensuring the existing entries about `Content-Length` parsing,
`Transfer-Encoding` multi-value support, and `setMaxBodySize()` enforcement
remain unchanged in content but are reformatted for readability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0c07b26d-b422-4c7b-923b-cc9daa4159d0
📒 Files selected for processing (5)
.gitignoreCHANGELOG.mdlibrary.jsonlibrary.propertiessrc/HttpCommon.h
💤 Files with no reviewable changes (1)
- .gitignore
This pull request primarily updates the project for a new release, synchronizing version metadata across files and introducing a changelog for improved documentation. No functional code changes are included; the focus is on project maintenance and clarity.
Release and metadata synchronization:
2.1.2inlibrary.json,library.properties, andsrc/HttpCommon.hto ensure consistency across all metadata sources. [1] [2] [3]library.jsonto use consistent array formatting forplatformsandframeworks.Documentation improvements:
CHANGELOG.mdfile detailing notable changes, bug fixes, performance improvements, and features for recent and past releases.Summary by CodeRabbit
Documentation
Chores