Skip to content

Bad object instanciation #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btry merged 2 commits into from
Feb 3, 2026
Merged

Bad object instanciation #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f4b046
fix(Impact\Embodied\Internal): bad object to compute embodied impact …
btry Feb 3, 2026
4692ab0
fix(Impact\Embodied\AbstractEmbodiedImpact): typo in error message
btry Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Impact/Embodied/AbstractEmbodiedImpact.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public function evaluateItem(): bool
Session::addMessageAfterRedirect(__('Connection to Boavizta failed.', 'carbon'), false, ERROR);
return false;
} catch (\RuntimeException $e) {
Session::addMessageAfterRedirect(__('Embodied impact evaluation valuation falied.', 'carbon'), false, ERROR);
Session::addMessageAfterRedirect(__('Embodied impact evaluation falied.', 'carbon'), false, ERROR);
return false;
}

Expand Down
7 changes: 4 additions & 3 deletions src/Impact/Embodied/Internal/Computer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
use Computer as GlpiComputer;
use GlpiPlugin\Carbon\DataTracking\TrackedFloat;
use ComputerModel as GlpiComputerModel;
use GlpiPlugin\Carbon\ComputerModel;
use GlpiPlugin\Carbon\Impact\Type;

/**
Expand All @@ -46,13 +47,13 @@ class Computer extends AbstractAsset

protected function doEvaluation(): ?array
{
if (GlpiComputerModel::isNewID($this->item->fields['networkequipmentmodels_id'])) {
if (GlpiComputerModel::isNewID($this->item->fields['computermodels_id'])) {
return [];
}

$model = new GlpiComputerModel();
$model = new ComputerModel();
$model->getFromDBByCrit([
'networkequipmentmodels_id' => $this->item->fields['networkequipmentmodels_id']
'computermodels_id' => $this->item->fields['computermodels_id']
]);
if ($model->isNewItem()) {
return [];
Expand Down
7 changes: 4 additions & 3 deletions src/Impact/Embodied/Internal/Monitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
use GlpiPlugin\Carbon\DataTracking\TrackedFloat;
use MonitorModel as GlpiMonitorModel;
use GlpiPlugin\Carbon\Impact\Type;
use GlpiPlugin\Carbon\MonitorModel;

/**
* This embodied impact
Expand All @@ -47,13 +48,13 @@ class Monitor extends AbstractAsset

protected function doEvaluation(): ?array
{
if (GlpiMonitorModel::isNewID($this->item->fields['networkequipmentmodels_id'])) {
if (GlpiMonitorModel::isNewID($this->item->fields['monitormodels_id'])) {
return [];
}

$model = new GlpiMonitorModel();
$model = new MonitorModel();
$model->getFromDBByCrit([
'networkequipmentmodels_id' => $this->item->fields['networkequipmentmodels_id']
'monitormodels_id' => $this->item->fields['monitormodels_id']
]);
if ($model->isNewItem()) {
return [];
Expand Down