Skip to content

Remove serial_number from DeviceInfo#400

Merged
bouwew merged 3 commits intomainfrom
remove-serial
Mar 1, 2026
Merged

Remove serial_number from DeviceInfo#400
bouwew merged 3 commits intomainfrom
remove-serial

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Feb 7, 2026

HA now shows the ZigBee MAC address, no need to use the serial-number for this.

Summary by CodeRabbit

  • Bug Fixes

    • Device identification for Plugwise USB in Home Assistant now uses ZigBee MAC addresses instead of a device serial number.
  • Documentation

    • Added changelog entry for release v0.59.1 describing the identification change.
  • Chores

    • Project and integration version updated to v0.59.1.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38fa218 and 08a2acd.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • custom_components/plugwise_usb/manifest.json
  • pyproject.toml
✅ Files skipped from review due to trivial changes (1)
  • custom_components/plugwise_usb/manifest.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

Walkthrough

Removed the serial_number field from device registry entries and DeviceInfo in the Plugwise USB component; updated package and manifest versions and added a CHANGELOG entry documenting the change to show ZigBee MAC addresses in Home Assistant.

Changes

Cohort / File(s) Summary
Device registration & entity
custom_components/plugwise_usb/__init__.py, custom_components/plugwise_usb/entity.py
Removed serial_number from device registry entry creation and from DeviceInfo returned by Plugwise USB entities; device identification now relies on ZigBee MAC addresses.
Metadata / Packaging
custom_components/plugwise_usb/manifest.json, pyproject.toml
Bumped version from 0.59.0 to 0.59.1.
Changelog
CHANGELOG.md
Added v0.59.1 entry documenting removal of serial_number and display of ZigBee MAC addresses in Home Assistant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • dirixmjm
  • ArnoutD

Poem

🐰 The serial hopped away today,
MAC addresses lead the way,
ZigBee hums a tidy tune,
Devices known by evening noon,
A little hop, a simpler play. 🎋

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove serial_number from DeviceInfo' directly and clearly describes the main change in the changeset—removal of the serial_number field from DeviceInfo across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-serial

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bouwew bouwew marked this pull request as ready for review March 1, 2026 14:44
@bouwew bouwew requested a review from a team as a code owner March 1, 2026 14:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2026

@bouwew bouwew merged commit 31de893 into main Mar 1, 2026
12 checks passed
@bouwew bouwew deleted the remove-serial branch March 1, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant