Change write connection to read connection in attachMetadatabase #396
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connections are created inside GRDB
DatabasePoolinstances, they are done lazily for both read and write connections.At the moment, in
attachMetadatabase, we are creating a short-livedDatabasePooland instantly using it for a write connection to executeSELECT 1in order to ensure the database exists and is functional.The issue with this is that write connections require an exclusive lock on the file; usually, this is not an issue as when using a single
DatabasePoolinstance, these are queued serially, but if one of these lazy connections is created at the same time as anotherDatabasePoolinstance has the database locked, we end up with a SQLite exception:This PR changes that connection to a read one, which, with WAL enabled databases, can leverage the shared memory file and "play nicely" with other threads.
Fixes #394