Enable clippy linting in repo#1114
Open
lionel- wants to merge 6 commits intotask/clippy-manual-all-targetsfrom
Open
Enable clippy linting in repo#1114lionel- wants to merge 6 commits intotask/clippy-manual-all-targetsfrom
lionel- wants to merge 6 commits intotask/clippy-manual-all-targetsfrom
Conversation
Contributor
Author
|
oh clippy has LSP fixes! 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1113
Closes #1104
On CI. Config taken from https://github.com/astral-sh/ruff/blob/56eb6b62936142c6ab2bdf0d7b864e32399e02a8/.github/workflows/ci.yaml#L243-L263
In IDEs via rust-analyzer's
checkconfig.I'm a bit hesitant enabling it in rust-analyser because of this (from #1104 (comment)):
One UX downside to be aware of: After each edits, clippy runs longer checks on the repo, which locks other gestures requiring compilation (running tests etc).
But I guess we can override in our personal configs if we want a different workflow (check with clippy before sending PR).