Skip to content

pppd: do not rely on have_route_to(0) during auth. #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkroonza wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pppd: do not rely on have_route_to(0) during auth. #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pppd/auth.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,7 @@ auth_check_options(void)
* If we have a default route, require the peer to authenticate
* unless the noauth option was given or the real user is root.
*/
if (!auth_required && !allow_any_ip && have_route_to(0) && !privileged) {
if (!auth_required && !allow_any_ip && !privileged) {
auth_required = 1;
default_auth = 1;
}
Expand Down
10 changes: 5 additions & 5 deletions pppd/pppd.8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ so pppd will ask the peer not to escape any control characters.
To escape transmitted characters, use the \fIescape\fR option.
.TP
.B auth
Require the peer to authenticate itself before allowing network
packets to be sent or received. This option is the default if the
system has a default route. If neither this option nor the
\fInoauth\fR option is specified, pppd will only allow the peer to use
IP addresses to which the system does not already have a route.
Require the peer to authenticate itself before allowing network packets to be
sent or received. For security reasons this option is the default if pppd is
executed as a non-privileged user. If neither this option nor the \fInoauth\fR
option is specified, pppd will only allow the peer to use IP addresses to which
the system does not already have a route.
.TP
.B call \fIname
Read additional options from the file /etc/ppp/peers/\fIname\fR. This
Expand Down
Loading