Hoist noise generation in encaps into separate helper

[hanno-becker]

• Builds on Rename mlk_keypair_getnoise() to mlk_keypair_getnoise_eta1() #1629

Analogous to @rod-chapman's #1621, but this time primarily for uniformity.

[rod-chapman]

Suerly the title of the PR is wrong? This is about "enc" not "keygen"??

[rod-chapman]

Where is the Makefile for the new helper function? Forgotten "git add" ?

[mkannwischer]

This does not look ready, @hanno-becker? Marking as draft.

[oqs-bot]

CBMC Results (ML-KEM-768)

Full Results (191 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	1240s	1261s	-1.7%
mlk_indcpa_keypair_derand	✅	187s	190s	-2%
mlk_indcpa_enc	✅	149s	194s	-23%
mlk_rej_uniform_c	✅	96s	92s	+4%
mlk_polyvec_basemul_acc_montgomery_cached_c	✅	65s	66s	-2%
mlk_poly_rej_uniform	✅	39s	39s	+0%
mlk_ntt_layer	✅	28s	29s	-3%
mlk_poly_reduce_native	✅	26s	27s	-4%
mlk_polyvec_add	✅	25s	28s	-11%
mlk_keccak_squeezeblocks_x4	✅	24s	26s	-8%
keccakf1600x4_permute_native_x4	✅	21s	18s	+17%
mlk_indcpa_dec	✅	21s	16s	+31%
polyvec_basemul_acc_montgomery_cached_native	✅	21s	22s	-5%
poly_ntt_native	✅	20s	21s	-5%
mlk_poly_decompress_d10_native	✅	14s	13s	+8%
mlk_poly_decompress_d4_native	✅	13s	15s	-13%
mlk_poly_rej_uniform_x4	✅	11s	10s	+10%
mlk_fqmul	✅	8s	5s	+60%
mlk_ntt_butterfly_block	✅	8s	7s	+14%
mlk_poly_frombytes_native	✅	8s	10s	-20%
mlk_invntt_layer	✅	7s	4s	+75%
mlk_keccak_absorb_once	✅	7s	4s	+75%
mlk_keccak_absorb_once_x4	✅	7s	9s	-22%
mlk_keccak_squeezeblocks	✅	7s	8s	-12%
mlk_poly_frommsg	✅	7s	6s	+17%
mlk_polymat_permute_bitrev_to_custom	✅	7s	5s	+40%
mlk_keccak_squeeze_once	✅	6s	6s	+0%
mlk_poly_ntt	✅	6s	3s	+100%
mlk_shake128_absorb_once	✅	6s	2s	+200%
keccakf1600x4_xor_bytes_native	✅	5s	3s	+67%
mlk_poly_add	✅	5s	4s	+25%
poly_frombytes_native_x86_64	✅	5s	5s	+0%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64	✅	5s	3s	+67%
keccak_f1600_x1_native_aarch64_v84a	✅	4s	2s	+100%
kem_check_pk	✅	4s	3s	+33%
mlk_check_pct	✅	4s	1s	+300%
mlk_ct_memcmp	✅	4s	1s	+300%
mlk_keccakf1600_permute_c	✅	4s	4s	+0%
mlk_keccakf1600x4_xor_bytes	✅	4s	3s	+33%
mlk_poly_getnoise_eta1_4x_native	✅	4s	3s	+33%
mlk_poly_mulcache_compute_c	✅	4s	2s	+100%
mlk_poly_reduce_c	✅	4s	2s	+100%
mlk_polyvec_compress_du	✅	4s	2s	+100%
mlk_polyvec_permute_bitrev_to_custom_native	✅	4s	4s	+0%
mlk_scalar_decompress_d10	✅	4s	4s	+0%
mlk_shake256x4	✅	4s	4s	+0%
ntt_native_x86_64	✅	4s	4s	+0%
poly_compress_d5_native_x86_64	✅	4s	2s	+100%
poly_decompress_d4_native_x86_64	✅	4s	5s	-20%
poly_mulcache_compute_native_aarch64	✅	4s	1s	+300%
poly_reduce_native_x86_64	✅	4s	2s	+100%
intt_native_aarch64	✅	3s	2s	+50%
intt_native_x86_64	✅	3s	2s	+50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid	✅	3s	1s	+200%
keccak_f1600_x4_native_avx2	✅	3s	2s	+50%
keccakf1600_permute_native	✅	3s	2s	+50%
kem_check_sk	✅	3s	3s	+0%
kem_dec	✅	3s	6s	-50%
kem_keypair	✅	3s	1s	+200%
kem_keypair_derand	✅	3s	3s	+0%
mlk_ct_cmov_zero	✅	3s	2s	+50%
mlk_ct_get_optblocker_i32	✅	3s	3s	+0%
mlk_gen_matrix	✅	3s	4s	-25%
mlk_gen_matrix_serial	✅	3s	4s	-25%
mlk_keccakf1600_extract_bytes	✅	3s	1s	+200%
mlk_keccakf1600_extract_bytes (big endian)	✅	3s	2s	+50%
mlk_keccakf1600_xor_bytes (big endian)	✅	3s	2s	+50%
mlk_keccakf1600x4_extract_bytes_c	✅	3s	1s	+200%
mlk_keccakf1600x4_permute	✅	3s	1s	+200%
mlk_poly_cbd_eta2	✅	3s	2s	+50%
mlk_poly_compress_du	✅	3s	3s	+0%
mlk_poly_decompress_d11_native	✅	3s	4s	-25%
mlk_poly_invntt_tomont	✅	3s	3s	+0%
mlk_poly_ntt_c	✅	3s	3s	+0%
mlk_poly_tomont_c	✅	3s	2s	+50%
mlk_poly_tomsg	✅	3s	1s	+200%
mlk_polyvec_decompress_du	✅	3s	1s	+200%
mlk_polyvec_frombytes	✅	3s	6s	-50%
mlk_polyvec_mulcache_compute	✅	3s	2s	+50%
mlk_polyvec_permute_bitrev_to_custom	✅	3s	1s	+200%
mlk_scalar_compress_d1	✅	3s	1s	+200%
mlk_scalar_compress_d11	✅	3s	3s	+0%
mlk_scalar_decompress_d11	✅	3s	2s	+50%
mlk_value_barrier_u8	✅	3s	1s	+200%
poly_compress_d11_native_x86_64	✅	3s	1s	+200%
poly_decompress_d10_native_x86_64	✅	3s	4s	-25%
poly_decompress_d11_native_x86_64	✅	3s	3s	+0%
poly_getnoise_eta1122_4x_native	✅	3s	2s	+50%
poly_invntt_tomont_native	✅	3s	1s	+200%
poly_mulcache_compute_native_x86_64	✅	3s	3s	+0%
poly_reduce_native_aarch64	✅	3s	1s	+200%
poly_tobytes_native_aarch64	✅	3s	2s	+50%
poly_tomont_native_x86_64	✅	3s	3s	+0%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64	✅	3s	2s	+50%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64	✅	3s	2s	+50%
rej_uniform_native	✅	3s	2s	+50%
sys_check_capability	✅	3s	2s	+50%
keccak_f1600_x1_native_aarch64	✅	2s	1s	+100%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid	✅	2s	3s	-33%
kem_enc	✅	2s	3s	-33%
kem_enc_derand	✅	2s	5s	-60%
mlk_barrett_reduce	✅	2s	1s	+100%
mlk_ct_cmask_neg_i16	✅	2s	1s	+100%
mlk_ct_cmask_nonzero_u8	✅	2s	4s	-50%
mlk_ct_get_optblocker_u32	✅	2s	2s	+0%
mlk_ct_sel_uint8	✅	2s	2s	+0%
mlk_enc_getnoise_eta1_eta2	✅	2s	-	new
mlk_keccakf1600_permute	✅	2s	2s	+0%
mlk_keccakf1600x4_xor_bytes_c	✅	2s	3s	-33%
mlk_keypair_getnoise_eta1	✅	2s	2s	+0%
mlk_matvec_mul	✅	2s	3s	-33%
mlk_montgomery_reduce	✅	2s	2s	+0%
mlk_poly_cbd_eta1	✅	2s	3s	-33%
mlk_poly_compress_d10	✅	2s	2s	+0%
mlk_poly_compress_d10_c	✅	2s	1s	+100%
mlk_poly_compress_d10_native	✅	2s	1s	+100%
mlk_poly_compress_d11	✅	2s	1s	+100%
mlk_poly_compress_d11_c	✅	2s	2s	+0%
mlk_poly_compress_d11_native	✅	2s	3s	-33%
mlk_poly_compress_d4_c	✅	2s	2s	+0%
mlk_poly_compress_d4_native	✅	2s	2s	+0%
mlk_poly_compress_d5_c	✅	2s	3s	-33%
mlk_poly_compress_d5_native	✅	2s	2s	+0%
mlk_poly_compress_dv	✅	2s	2s	+0%
mlk_poly_decompress_d10	✅	2s	1s	+100%
mlk_poly_decompress_d10_c	✅	2s	3s	-33%
mlk_poly_decompress_d11	✅	2s	2s	+0%
mlk_poly_decompress_d4	✅	2s	3s	-33%
mlk_poly_decompress_d4_c	✅	2s	2s	+0%
mlk_poly_decompress_d5	✅	2s	2s	+0%
mlk_poly_decompress_d5_c	✅	2s	3s	-33%
mlk_poly_decompress_du	✅	2s	3s	-33%
mlk_poly_decompress_dv	✅	2s	2s	+0%
mlk_poly_frombytes	✅	2s	4s	-50%
mlk_poly_frombytes_c	✅	2s	2s	+0%
mlk_poly_getnoise_eta1122_4x	✅	2s	2s	+0%
mlk_poly_getnoise_eta1_4x	✅	2s	2s	+0%
mlk_poly_getnoise_eta2	✅	2s	3s	-33%
mlk_poly_invntt_tomont_c	✅	2s	2s	+0%
mlk_poly_mulcache_compute	✅	2s	2s	+0%
mlk_poly_mulcache_compute_native	✅	2s	3s	-33%
mlk_poly_reduce	✅	2s	1s	+100%
mlk_poly_sub	✅	2s	1s	+100%
mlk_poly_tobytes_c	✅	2s	2s	+0%
mlk_poly_tomont_native	✅	2s	2s	+0%
mlk_polyvec_basemul_acc_montgomery_cached	✅	2s	1s	+100%
mlk_polyvec_reduce	✅	2s	3s	-33%
mlk_rej_uniform	✅	2s	2s	+0%
mlk_scalar_compress_d10	✅	2s	2s	+0%
mlk_scalar_compress_d4	✅	2s	2s	+0%
mlk_scalar_compress_d5	✅	2s	5s	-60%
mlk_scalar_decompress_d4	✅	2s	2s	+0%
mlk_scalar_decompress_d5	✅	2s	4s	-50%
mlk_scalar_signed_to_unsigned_q	✅	2s	2s	+0%
mlk_sha3_256	✅	2s	3s	-33%
mlk_sha3_512	✅	2s	5s	-60%
mlk_shake128x4_squeezeblocks	✅	2s	3s	-33%
mlk_value_barrier_i32	✅	2s	2s	+0%
mlk_value_barrier_u32	✅	2s	2s	+0%
ntt_native_aarch64	✅	2s	3s	-33%
poly_compress_d10_native_x86_64	✅	2s	3s	-33%
poly_compress_d4_native_x86_64	✅	2s	2s	+0%
poly_decompress_d5_native_x86_64	✅	2s	2s	+0%
poly_tomont_native_aarch64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64	✅	2s	3s	-33%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64	✅	2s	2s	+0%
rej_uniform_native_aarch64	✅	2s	2s	+0%
rej_uniform_native_x86_64	✅	2s	1s	+100%
keccak_f1600_x4_native_aarch64_v84a	✅	1s	2s	-50%
keccakf1600x4_extract_bytes_native	✅	1s	2s	-50%
mlk_ct_cmask_nonzero_u16	✅	1s	3s	-67%
mlk_ct_get_optblocker_u8	✅	1s	2s	-50%
mlk_ct_sel_int16	✅	1s	3s	-67%
mlk_keccakf1600_xor_bytes	✅	1s	3s	-67%
mlk_keccakf1600x4_extract_bytes	✅	1s	2s	-50%
mlk_poly_compress_d4	✅	1s	2s	-50%
mlk_poly_compress_d5	✅	1s	1s	+0%
mlk_poly_decompress_d11_c	✅	1s	2s	-50%
mlk_poly_decompress_d5_native	✅	1s	1s	+0%
mlk_poly_tobytes	✅	1s	1s	+0%
mlk_poly_tobytes_native	✅	1s	4s	-75%
mlk_poly_tomont	✅	1s	3s	-67%
mlk_polyvec_invntt_tomont	✅	1s	2s	-50%
mlk_polyvec_ntt	✅	1s	2s	-50%
mlk_polyvec_tobytes	✅	1s	4s	-75%
mlk_polyvec_tomont	✅	1s	1s	+0%
mlk_shake128_squeezeblocks	✅	1s	1s	+0%
mlk_shake128x4_absorb_once	✅	1s	1s	+0%
mlk_shake256	✅	1s	2s	-50%
nttunpack_native_x86_64	✅	1s	4s	-75%
poly_tobytes_native_x86_64	✅	1s	2s	-50%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64	✅	1s	4s	-75%

[oqs-bot]

CBMC Results (ML-KEM-1024)

Full Results (191 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	1328s	1374s	-3.3%
mlk_indcpa_enc	✅	179s	276s	-35%
mlk_indcpa_keypair_derand	✅	130s	129s	+1%
mlk_rej_uniform_c	✅	113s	99s	+14%
mlk_polyvec_basemul_acc_montgomery_cached_c	✅	75s	63s	+19%
mlk_poly_rej_uniform	✅	42s	44s	-5%
polyvec_basemul_acc_montgomery_cached_native	✅	41s	40s	+2%
mlk_ntt_layer	✅	38s	28s	+36%
mlk_poly_reduce_native	✅	28s	26s	+8%
mlk_polyvec_add	✅	26s	28s	-7%
mlk_keccak_squeezeblocks_x4	✅	25s	24s	+4%
poly_ntt_native	✅	24s	21s	+14%
keccakf1600x4_permute_native_x4	✅	23s	19s	+21%
mlk_indcpa_dec	✅	18s	18s	+0%
mlk_poly_decompress_d11_native	✅	16s	15s	+7%
mlk_poly_decompress_d5_native	✅	14s	17s	-18%
mlk_polymat_permute_bitrev_to_custom	✅	11s	10s	+10%
mlk_invntt_layer	✅	9s	7s	+29%
mlk_keccak_absorb_once_x4	✅	9s	9s	+0%
mlk_ntt_butterfly_block	✅	9s	10s	-10%
mlk_poly_frombytes_native	✅	9s	8s	+12%
mlk_poly_frommsg	✅	9s	9s	+0%
mlk_poly_rej_uniform_x4	✅	8s	8s	+0%
kem_dec	✅	7s	8s	-12%
mlk_fqmul	✅	7s	7s	+0%
mlk_gen_matrix	✅	7s	6s	+17%
mlk_keccak_squeeze_once	✅	7s	5s	+40%
mlk_poly_compress_d11_c	✅	7s	6s	+17%
mlk_polyvec_ntt	✅	7s	7s	+0%
mlk_gen_matrix_serial	✅	6s	5s	+20%
mlk_keccak_squeezeblocks	✅	6s	10s	-40%
mlk_keccakf1600_permute_c	✅	6s	4s	+50%
mlk_poly_compress_d4_c	✅	6s	2s	+200%
mlk_poly_decompress_dv	✅	5s	3s	+67%
poly_decompress_d5_native_x86_64	✅	5s	5s	+0%
poly_frombytes_native_x86_64	✅	5s	7s	-29%
poly_tobytes_native_aarch64	✅	5s	2s	+150%
kem_check_pk	✅	4s	5s	-20%
kem_check_sk	✅	4s	3s	+33%
kem_enc_derand	✅	4s	5s	-20%
mlk_ct_cmask_nonzero_u16	✅	4s	2s	+100%
mlk_keccak_absorb_once	✅	4s	4s	+0%
mlk_keccakf1600_xor_bytes (big endian)	✅	4s	3s	+33%
mlk_poly_add	✅	4s	5s	-20%
mlk_poly_compress_d5	✅	4s	4s	+0%
mlk_poly_decompress_d11_c	✅	4s	3s	+33%
mlk_poly_getnoise_eta1_4x	✅	4s	6s	-33%
mlk_poly_getnoise_eta1_4x_native	✅	4s	3s	+33%
mlk_poly_getnoise_eta2	✅	4s	2s	+100%
mlk_poly_tomont_c	✅	4s	3s	+33%
mlk_polyvec_basemul_acc_montgomery_cached	✅	4s	1s	+300%
mlk_polyvec_frombytes	✅	4s	1s	+300%
mlk_polyvec_mulcache_compute	✅	4s	3s	+33%
mlk_scalar_compress_d4	✅	4s	3s	+33%
mlk_sha3_256	✅	4s	4s	+0%
ntt_native_aarch64	✅	4s	3s	+33%
poly_decompress_d11_native_x86_64	✅	4s	3s	+33%
poly_tomont_native_aarch64	✅	4s	1s	+300%
keccakf1600x4_xor_bytes_native	✅	3s	2s	+50%
kem_enc	✅	3s	2s	+50%
mlk_barrett_reduce	✅	3s	2s	+50%
mlk_ct_cmov_zero	✅	3s	4s	-25%
mlk_ct_get_optblocker_i32	✅	3s	2s	+50%
mlk_ct_memcmp	✅	3s	2s	+50%
mlk_ct_sel_int16	✅	3s	3s	+0%
mlk_keccakf1600_xor_bytes	✅	3s	3s	+0%
mlk_keccakf1600x4_xor_bytes	✅	3s	2s	+50%
mlk_keccakf1600x4_xor_bytes_c	✅	3s	2s	+50%
mlk_keypair_getnoise_eta1	✅	3s	2s	+50%
mlk_poly_cbd_eta2	✅	3s	2s	+50%
mlk_poly_compress_d11	✅	3s	2s	+50%
mlk_poly_compress_d11_native	✅	3s	2s	+50%
mlk_poly_compress_du	✅	3s	3s	+0%
mlk_poly_decompress_d10	✅	3s	1s	+200%
mlk_poly_decompress_d4_native	✅	3s	3s	+0%
mlk_poly_mulcache_compute	✅	3s	3s	+0%
mlk_poly_mulcache_compute_c	✅	3s	2s	+50%
mlk_poly_mulcache_compute_native	✅	3s	1s	+200%
mlk_poly_ntt	✅	3s	3s	+0%
mlk_poly_reduce	✅	3s	1s	+200%
mlk_poly_sub	✅	3s	3s	+0%
mlk_poly_tobytes	✅	3s	5s	-40%
mlk_poly_tobytes_c	✅	3s	1s	+200%
mlk_poly_tobytes_native	✅	3s	2s	+50%
mlk_poly_tomsg	✅	3s	2s	+50%
mlk_polyvec_compress_du	✅	3s	3s	+0%
mlk_polyvec_permute_bitrev_to_custom	✅	3s	3s	+0%
mlk_polyvec_permute_bitrev_to_custom_native	✅	3s	1s	+200%
mlk_polyvec_reduce	✅	3s	3s	+0%
mlk_polyvec_tobytes	✅	3s	3s	+0%
mlk_polyvec_tomont	✅	3s	2s	+50%
mlk_scalar_compress_d11	✅	3s	3s	+0%
mlk_scalar_decompress_d4	✅	3s	4s	-25%
mlk_sha3_512	✅	3s	2s	+50%
mlk_shake128_squeezeblocks	✅	3s	3s	+0%
mlk_shake256x4	✅	3s	6s	-50%
mlk_value_barrier_i32	✅	3s	4s	-25%
mlk_value_barrier_u8	✅	3s	1s	+200%
ntt_native_x86_64	✅	3s	2s	+50%
nttunpack_native_x86_64	✅	3s	2s	+50%
poly_compress_d10_native_x86_64	✅	3s	3s	+0%
poly_compress_d11_native_x86_64	✅	3s	2s	+50%
poly_getnoise_eta1122_4x_native	✅	3s	2s	+50%
poly_invntt_tomont_native	✅	3s	2s	+50%
poly_reduce_native_aarch64	✅	3s	1s	+200%
poly_reduce_native_x86_64	✅	3s	2s	+50%
poly_tobytes_native_x86_64	✅	3s	2s	+50%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64	✅	3s	3s	+0%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64	✅	3s	2s	+50%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64	✅	3s	3s	+0%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64	✅	3s	4s	-25%
rej_uniform_native_aarch64	✅	3s	2s	+50%
rej_uniform_native_x86_64	✅	3s	3s	+0%
intt_native_aarch64	✅	2s	4s	-50%
intt_native_x86_64	✅	2s	2s	+0%
keccak_f1600_x1_native_aarch64	✅	2s	3s	-33%
keccak_f1600_x4_native_aarch64_v84a	✅	2s	2s	+0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid	✅	2s	1s	+100%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid	✅	2s	3s	-33%
keccak_f1600_x4_native_avx2	✅	2s	3s	-33%
keccakf1600_permute_native	✅	2s	1s	+100%
keccakf1600x4_extract_bytes_native	✅	2s	1s	+100%
kem_keypair	✅	2s	2s	+0%
kem_keypair_derand	✅	2s	4s	-50%
mlk_check_pct	✅	2s	1s	+100%
mlk_ct_get_optblocker_u32	✅	2s	2s	+0%
mlk_ct_get_optblocker_u8	✅	2s	1s	+100%
mlk_ct_sel_uint8	✅	2s	2s	+0%
mlk_enc_getnoise_eta1_eta2	✅	2s	-	new
mlk_keccakf1600_extract_bytes	✅	2s	2s	+0%
mlk_keccakf1600_extract_bytes (big endian)	✅	2s	2s	+0%
mlk_keccakf1600_permute	✅	2s	1s	+100%
mlk_keccakf1600x4_extract_bytes_c	✅	2s	1s	+100%
mlk_matvec_mul	✅	2s	2s	+0%
mlk_montgomery_reduce	✅	2s	3s	-33%
mlk_poly_cbd_eta1	✅	2s	3s	-33%
mlk_poly_compress_d10	✅	2s	2s	+0%
mlk_poly_compress_d10_c	✅	2s	2s	+0%
mlk_poly_compress_d10_native	✅	2s	3s	-33%
mlk_poly_compress_d4	✅	2s	4s	-50%
mlk_poly_compress_d5_c	✅	2s	2s	+0%
mlk_poly_decompress_d10_c	✅	2s	2s	+0%
mlk_poly_decompress_d10_native	✅	2s	2s	+0%
mlk_poly_decompress_d4_c	✅	2s	1s	+100%
mlk_poly_decompress_d5	✅	2s	5s	-60%
mlk_poly_decompress_du	✅	2s	3s	-33%
mlk_poly_frombytes_c	✅	2s	1s	+100%
mlk_poly_getnoise_eta1122_4x	✅	2s	3s	-33%
mlk_poly_invntt_tomont	✅	2s	3s	-33%
mlk_poly_invntt_tomont_c	✅	2s	5s	-60%
mlk_poly_ntt_c	✅	2s	4s	-50%
mlk_poly_reduce_c	✅	2s	1s	+100%
mlk_poly_tomont	✅	2s	1s	+100%
mlk_poly_tomont_native	✅	2s	1s	+100%
mlk_polyvec_invntt_tomont	✅	2s	2s	+0%
mlk_scalar_compress_d1	✅	2s	2s	+0%
mlk_scalar_decompress_d10	✅	2s	2s	+0%
mlk_scalar_decompress_d5	✅	2s	2s	+0%
mlk_scalar_signed_to_unsigned_q	✅	2s	3s	-33%
mlk_shake128x4_absorb_once	✅	2s	3s	-33%
mlk_shake128x4_squeezeblocks	✅	2s	4s	-50%
mlk_shake256	✅	2s	3s	-33%
poly_compress_d4_native_x86_64	✅	2s	2s	+0%
poly_compress_d5_native_x86_64	✅	2s	4s	-50%
poly_decompress_d10_native_x86_64	✅	2s	3s	-33%
poly_decompress_d4_native_x86_64	✅	2s	3s	-33%
poly_mulcache_compute_native_aarch64	✅	2s	2s	+0%
poly_mulcache_compute_native_x86_64	✅	2s	3s	-33%
poly_tomont_native_x86_64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64	✅	2s	4s	-50%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64	✅	2s	3s	-33%
keccak_f1600_x1_native_aarch64_v84a	✅	1s	2s	-50%
mlk_ct_cmask_neg_i16	✅	1s	3s	-67%
mlk_ct_cmask_nonzero_u8	✅	1s	3s	-67%
mlk_keccakf1600x4_extract_bytes	✅	1s	2s	-50%
mlk_keccakf1600x4_permute	✅	1s	2s	-50%
mlk_poly_compress_d4_native	✅	1s	3s	-67%
mlk_poly_compress_d5_native	✅	1s	2s	-50%
mlk_poly_compress_dv	✅	1s	2s	-50%
mlk_poly_decompress_d11	✅	1s	2s	-50%
mlk_poly_decompress_d4	✅	1s	3s	-67%
mlk_poly_decompress_d5_c	✅	1s	3s	-67%
mlk_poly_frombytes	✅	1s	3s	-67%
mlk_polyvec_decompress_du	✅	1s	3s	-67%
mlk_rej_uniform	✅	1s	2s	-50%
mlk_scalar_compress_d10	✅	1s	2s	-50%
mlk_scalar_compress_d5	✅	1s	2s	-50%
mlk_scalar_decompress_d11	✅	1s	3s	-67%
mlk_shake128_absorb_once	✅	1s	2s	-50%
mlk_value_barrier_u32	✅	1s	1s	+0%
rej_uniform_native	✅	1s	2s	-50%
sys_check_capability	✅	1s	2s	-50%

[oqs-bot]

CBMC Results (ML-KEM-512)

Full Results (191 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	1229s	1358s	-9.5%
mlk_indcpa_keypair_derand	✅	229s	242s	-5%
mlk_indcpa_enc	✅	116s	221s	-48%
mlk_rej_uniform_c	✅	91s	98s	-7%
mlk_polyvec_basemul_acc_montgomery_cached_c	✅	67s	67s	+0%
mlk_poly_rej_uniform	✅	45s	41s	+10%
mlk_ntt_layer	✅	35s	32s	+9%
mlk_poly_reduce_native	✅	25s	28s	-11%
mlk_keccak_squeezeblocks_x4	✅	23s	26s	-12%
poly_ntt_native	✅	23s	21s	+10%
keccakf1600x4_permute_native_x4	✅	17s	20s	-15%
mlk_poly_decompress_d4_native	✅	15s	15s	+0%
mlk_polyvec_add	✅	15s	17s	-12%
mlk_poly_decompress_d10_native	✅	14s	17s	-18%
mlk_indcpa_dec	✅	11s	9s	+22%
polyvec_basemul_acc_montgomery_cached_native	✅	11s	11s	+0%
mlk_ntt_butterfly_block	✅	9s	7s	+29%
mlk_poly_frommsg	✅	9s	8s	+12%
mlk_poly_rej_uniform_x4	✅	9s	9s	+0%
mlk_keccak_absorb_once_x4	✅	8s	8s	+0%
mlk_keccak_squeeze_once	✅	8s	7s	+14%
mlk_polymat_permute_bitrev_to_custom	✅	8s	8s	+0%
kem_dec	✅	6s	4s	+50%
kem_enc	✅	6s	2s	+200%
mlk_keccak_squeezeblocks	✅	6s	8s	-25%
mlk_poly_add	✅	6s	6s	+0%
mlk_poly_frombytes_native	✅	6s	9s	-33%
poly_frombytes_native_x86_64	✅	6s	5s	+20%
kem_check_pk	✅	5s	4s	+25%
mlk_fqmul	✅	5s	8s	-38%
mlk_invntt_layer	✅	5s	6s	-17%
mlk_keccak_absorb_once	✅	5s	4s	+25%
mlk_poly_compress_d4_c	✅	5s	2s	+150%
mlk_poly_decompress_d5_native	✅	5s	3s	+67%
mlk_poly_mulcache_compute_c	✅	5s	4s	+25%
mlk_poly_sub	✅	5s	3s	+67%
mlk_poly_tomsg	✅	5s	2s	+150%
mlk_scalar_decompress_d10	✅	5s	2s	+150%
kem_keypair_derand	✅	4s	3s	+33%
mlk_keccakf1600_permute_c	✅	4s	2s	+100%
mlk_poly_getnoise_eta2	✅	4s	3s	+33%
mlk_poly_mulcache_compute_native	✅	4s	3s	+33%
mlk_polyvec_basemul_acc_montgomery_cached	✅	4s	4s	+0%
mlk_polyvec_compress_du	✅	4s	1s	+300%
mlk_polyvec_frombytes	✅	4s	2s	+100%
mlk_scalar_compress_d1	✅	4s	2s	+100%
mlk_scalar_decompress_d5	✅	4s	2s	+100%
mlk_value_barrier_u8	✅	4s	3s	+33%
poly_decompress_d10_native_x86_64	✅	4s	5s	-20%
polyvec_basemul_acc_montgomery_cached_k3_native_aarch64	✅	4s	3s	+33%
intt_native_x86_64	✅	3s	2s	+50%
keccak_f1600_x4_native_avx2	✅	3s	1s	+200%
keccakf1600x4_extract_bytes_native	✅	3s	4s	-25%
kem_check_sk	✅	3s	2s	+50%
kem_enc_derand	✅	3s	5s	-40%
kem_keypair	✅	3s	4s	-25%
mlk_barrett_reduce	✅	3s	3s	+0%
mlk_check_pct	✅	3s	2s	+50%
mlk_ct_cmask_nonzero_u16	✅	3s	3s	+0%
mlk_ct_cmask_nonzero_u8	✅	3s	1s	+200%
mlk_ct_cmov_zero	✅	3s	4s	-25%
mlk_ct_get_optblocker_i32	✅	3s	2s	+50%
mlk_ct_sel_int16	✅	3s	2s	+50%
mlk_enc_getnoise_eta1_eta2	✅	3s	-	new
mlk_gen_matrix_serial	✅	3s	3s	+0%
mlk_keccakf1600x4_extract_bytes	✅	3s	4s	-25%
mlk_keypair_getnoise_eta1	✅	3s	2s	+50%
mlk_matvec_mul	✅	3s	4s	-25%
mlk_poly_compress_d11	✅	3s	2s	+50%
mlk_poly_compress_d11_native	✅	3s	3s	+0%
mlk_poly_compress_d4_native	✅	3s	2s	+50%
mlk_poly_compress_du	✅	3s	2s	+50%
mlk_poly_compress_dv	✅	3s	1s	+200%
mlk_poly_decompress_d11	✅	3s	2s	+50%
mlk_poly_decompress_d4_c	✅	3s	2s	+50%
mlk_poly_getnoise_eta1122_4x	✅	3s	4s	-25%
mlk_poly_invntt_tomont	✅	3s	4s	-25%
mlk_poly_mulcache_compute	✅	3s	3s	+0%
mlk_poly_ntt_c	✅	3s	3s	+0%
mlk_poly_reduce_c	✅	3s	4s	-25%
mlk_poly_tobytes	✅	3s	2s	+50%
mlk_polyvec_decompress_du	✅	3s	2s	+50%
mlk_polyvec_ntt	✅	3s	2s	+50%
mlk_polyvec_permute_bitrev_to_custom	✅	3s	2s	+50%
mlk_polyvec_tomont	✅	3s	2s	+50%
mlk_shake128x4_absorb_once	✅	3s	1s	+200%
mlk_shake256x4	✅	3s	3s	+0%
mlk_value_barrier_i32	✅	3s	2s	+50%
ntt_native_aarch64	✅	3s	4s	-25%
poly_decompress_d11_native_x86_64	✅	3s	2s	+50%
poly_decompress_d4_native_x86_64	✅	3s	3s	+0%
poly_decompress_d5_native_x86_64	✅	3s	2s	+50%
poly_getnoise_eta1122_4x_native	✅	3s	4s	-25%
poly_reduce_native_x86_64	✅	3s	3s	+0%
poly_tobytes_native_x86_64	✅	3s	2s	+50%
poly_tomont_native_aarch64	✅	3s	2s	+50%
polyvec_basemul_acc_montgomery_cached_k2_native_aarch64	✅	3s	1s	+200%
rej_uniform_native	✅	3s	3s	+0%
rej_uniform_native_x86_64	✅	3s	1s	+200%
sys_check_capability	✅	3s	3s	+0%
keccak_f1600_x1_native_aarch64_v84a	✅	2s	1s	+100%
keccak_f1600_x4_native_aarch64_v84a	✅	2s	2s	+0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid	✅	2s	3s	-33%
keccakf1600_permute_native	✅	2s	2s	+0%
keccakf1600x4_xor_bytes_native	✅	2s	3s	-33%
mlk_ct_cmask_neg_i16	✅	2s	3s	-33%
mlk_ct_memcmp	✅	2s	1s	+100%
mlk_ct_sel_uint8	✅	2s	2s	+0%
mlk_gen_matrix	✅	2s	4s	-50%
mlk_keccakf1600_extract_bytes	✅	2s	2s	+0%
mlk_keccakf1600_extract_bytes (big endian)	✅	2s	2s	+0%
mlk_keccakf1600_permute	✅	2s	2s	+0%
mlk_keccakf1600_xor_bytes (big endian)	✅	2s	2s	+0%
mlk_keccakf1600x4_permute	✅	2s	1s	+100%
mlk_keccakf1600x4_xor_bytes_c	✅	2s	2s	+0%
mlk_montgomery_reduce	✅	2s	3s	-33%
mlk_poly_cbd_eta1	✅	2s	2s	+0%
mlk_poly_cbd_eta2	✅	2s	3s	-33%
mlk_poly_compress_d10	✅	2s	2s	+0%
mlk_poly_compress_d10_c	✅	2s	3s	-33%
mlk_poly_compress_d10_native	✅	2s	5s	-60%
mlk_poly_compress_d11_c	✅	2s	3s	-33%
mlk_poly_compress_d5	✅	2s	2s	+0%
mlk_poly_compress_d5_c	✅	2s	1s	+100%
mlk_poly_decompress_d11_native	✅	2s	1s	+100%
mlk_poly_decompress_d4	✅	2s	1s	+100%
mlk_poly_decompress_du	✅	2s	5s	-60%
mlk_poly_decompress_dv	✅	2s	3s	-33%
mlk_poly_frombytes	✅	2s	3s	-33%
mlk_poly_frombytes_c	✅	2s	3s	-33%
mlk_poly_getnoise_eta1_4x	✅	2s	2s	+0%
mlk_poly_getnoise_eta1_4x_native	✅	2s	3s	-33%
mlk_poly_invntt_tomont_c	✅	2s	2s	+0%
mlk_poly_ntt	✅	2s	3s	-33%
mlk_poly_reduce	✅	2s	3s	-33%
mlk_poly_tobytes_c	✅	2s	1s	+100%
mlk_poly_tobytes_native	✅	2s	2s	+0%
mlk_poly_tomont	✅	2s	1s	+100%
mlk_poly_tomont_c	✅	2s	2s	+0%
mlk_poly_tomont_native	✅	2s	4s	-50%
mlk_polyvec_invntt_tomont	✅	2s	2s	+0%
mlk_polyvec_mulcache_compute	✅	2s	1s	+100%
mlk_polyvec_permute_bitrev_to_custom_native	✅	2s	1s	+100%
mlk_polyvec_reduce	✅	2s	2s	+0%
mlk_polyvec_tobytes	✅	2s	4s	-50%
mlk_rej_uniform	✅	2s	3s	-33%
mlk_scalar_compress_d11	✅	2s	2s	+0%
mlk_scalar_compress_d5	✅	2s	2s	+0%
mlk_scalar_decompress_d11	✅	2s	4s	-50%
mlk_scalar_signed_to_unsigned_q	✅	2s	2s	+0%
mlk_sha3_256	✅	2s	2s	+0%
mlk_shake256	✅	2s	2s	+0%
ntt_native_x86_64	✅	2s	2s	+0%
nttunpack_native_x86_64	✅	2s	4s	-50%
poly_compress_d10_native_x86_64	✅	2s	4s	-50%
poly_compress_d4_native_x86_64	✅	2s	2s	+0%
poly_compress_d5_native_x86_64	✅	2s	2s	+0%
poly_invntt_tomont_native	✅	2s	2s	+0%
poly_mulcache_compute_native_aarch64	✅	2s	2s	+0%
poly_reduce_native_aarch64	✅	2s	3s	-33%
poly_tobytes_native_aarch64	✅	2s	1s	+100%
polyvec_basemul_acc_montgomery_cached_k2_native_x86_64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k3_native_x86_64	✅	2s	2s	+0%
polyvec_basemul_acc_montgomery_cached_k4_native_aarch64	✅	2s	6s	-67%
rej_uniform_native_aarch64	✅	2s	3s	-33%
intt_native_aarch64	✅	1s	3s	-67%
keccak_f1600_x1_native_aarch64	✅	1s	1s	+0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid	✅	1s	2s	-50%
mlk_ct_get_optblocker_u32	✅	1s	4s	-75%
mlk_ct_get_optblocker_u8	✅	1s	1s	+0%
mlk_keccakf1600_xor_bytes	✅	1s	2s	-50%
mlk_keccakf1600x4_extract_bytes_c	✅	1s	1s	+0%
mlk_keccakf1600x4_xor_bytes	✅	1s	3s	-67%
mlk_poly_compress_d4	✅	1s	2s	-50%
mlk_poly_compress_d5_native	✅	1s	2s	-50%
mlk_poly_decompress_d10	✅	1s	2s	-50%
mlk_poly_decompress_d10_c	✅	1s	3s	-67%
mlk_poly_decompress_d11_c	✅	1s	1s	+0%
mlk_poly_decompress_d5	✅	1s	2s	-50%
mlk_poly_decompress_d5_c	✅	1s	3s	-67%
mlk_scalar_compress_d10	✅	1s	3s	-67%
mlk_scalar_compress_d4	✅	1s	2s	-50%
mlk_scalar_decompress_d4	✅	1s	2s	-50%
mlk_sha3_512	✅	1s	2s	-50%
mlk_shake128_absorb_once	✅	1s	2s	-50%
mlk_shake128_squeezeblocks	✅	1s	2s	-50%
mlk_shake128x4_squeezeblocks	✅	1s	3s	-67%
mlk_value_barrier_u32	✅	1s	2s	-50%
poly_compress_d11_native_x86_64	✅	1s	2s	-50%
poly_mulcache_compute_native_x86_64	✅	1s	1s	+0%
poly_tomont_native_x86_64	✅	1s	1s	+0%
polyvec_basemul_acc_montgomery_cached_k4_native_x86_64	✅	1s	4s	-75%

[mkannwischer]

LGTM. Thanks @hanno-becker and @rod-chapman.