-
-
Notifications
You must be signed in to change notification settings - Fork 132
Add flow-over-heated-plate-two-meshes test case #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Does not differ from the flow-over-heated-plate for the OpenFOAM adapter
Fujikawas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this PR also result in changes of some other reference results?
The respective workflow at the moment always updates all results. You are right that this looks strange and is unnecessary, I opened an issue: #711 |
IshaanDesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a brief look. Aside from the confusing part of other tutorials' reference results being updated, the additions to the tutorial in question make sense.
Our flow-over-heated-plate-two-meshes tutorial has been broken since a few months. This PR adds it to the system tests (follow-up of precice/calculix-adapter#148). It serves as a test case for the CalculiX adapter with one data field/direction exchanged per mesh.
@Fujikawas @IshaanDesai since you are currently working on #696, you might be interested in reviewing this PR.
Checklist:
changelog-entries/<PRnumber>.md.