Make README example pass validation with EN16931 (exec alternative).#100
Closed
JulienPalard wants to merge 3 commits intopretix:masterfrom
Closed
Make README example pass validation with EN16931 (exec alternative).#100JulienPalard wants to merge 3 commits intopretix:masterfrom
JulienPalard wants to merge 3 commits intopretix:masterfrom
Conversation
1d9e786 to
1a187e4
Compare
1a187e4 to
fcbb9af
Compare
Contributor
Author
|
I implemented an alternative of this one, in #103, using cog instead of exec. I have a preference for the cog one, but I let the maintainers of this project decide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90.
Beware, I don't know what I'm doing.
I'm not an LLM, and I did not used an LLM to generate this though, but this may not be better as it's the first time I read
1. FACTUR-X 1.07.3 2025 05 15 FR VF.pdf, and spent time reading validation errors generated by the previous README example.(I'm very slowly starting to understand, hopefully, but this is huge.)
I also introduced a non-zero VAT to enrich the example.