ActionList: restore aria-describedby for inline descriptions#7706
ActionList: restore aria-describedby for inline descriptions#7706liuliu-dev wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 730869c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/17268 |
There was a problem hiding this comment.
Pull request overview
Fixes an accessibility regression in ActionList.Item where inline ActionList.Description IDs were incorrectly included in aria-labelledby instead of aria-describedby, restoring the intended ARIA relationships for descriptions.
Changes:
- Move inline description IDs out of
aria-labelledbyand intoaria-describedbyinActionList.Item. - Add unit tests asserting both inline and block descriptions are referenced via
aria-describedby(and not viaaria-labelledby). - Add a patch changeset documenting the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/ActionList/Item.tsx | Restores correct ARIA attribute composition for inline descriptions. |
| packages/react/src/ActionList/ActionList.test.tsx | Adds regression tests for inline/block description ARIA wiring. |
| .changeset/tough-ears-drive.md | Records a patch-level changeset for the ARIA regression fix. |
Fixes a regression introduced in #7554 where the memoization refactor accidentally moved inline
DescriptionIDs fromaria-describedbyintoaria-labelledby. This was originally set in #7529.Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist