Skip to content

ActionList: restore aria-describedby for inline descriptions#7706

Open
liuliu-dev wants to merge 3 commits intomainfrom
liuliu/restore-aria-describedby-for-inline-description
Open

ActionList: restore aria-describedby for inline descriptions#7706
liuliu-dev wants to merge 3 commits intomainfrom
liuliu/restore-aria-describedby-for-inline-description

Conversation

@liuliu-dev
Copy link
Copy Markdown
Contributor

Fixes a regression introduced in #7554 where the memoization refactor accidentally moved inline Description IDs from aria-describedby into aria-labelledby. This was originally set in #7529.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: 730869c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@primer-integration
Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/17268

@primer-integration
Copy link
Copy Markdown

Integration test results from github/github-ui:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@liuliu-dev liuliu-dev marked this pull request as ready for review March 27, 2026 18:33
@liuliu-dev liuliu-dev requested a review from a team as a code owner March 27, 2026 18:33
@liuliu-dev liuliu-dev requested review from TylerJDev and Copilot March 27, 2026 18:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an accessibility regression in ActionList.Item where inline ActionList.Description IDs were incorrectly included in aria-labelledby instead of aria-describedby, restoring the intended ARIA relationships for descriptions.

Changes:

  • Move inline description IDs out of aria-labelledby and into aria-describedby in ActionList.Item.
  • Add unit tests asserting both inline and block descriptions are referenced via aria-describedby (and not via aria-labelledby).
  • Add a patch changeset documenting the fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/ActionList/Item.tsx Restores correct ARIA attribute composition for inline descriptions.
packages/react/src/ActionList/ActionList.test.tsx Adds regression tests for inline/block description ARIA wiring.
.changeset/tough-ears-drive.md Records a patch-level changeset for the ARIA regression fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants