feat(gemini): extracting rate limit violations and retry-after information #1008
Open
cutlope wants to merge 2 commits intoprism-php:mainfrom
Open
feat(gemini): extracting rate limit violations and retry-after information #1008cutlope wants to merge 2 commits intoprism-php:mainfrom
cutlope wants to merge 2 commits intoprism-php:mainfrom
Conversation
- Added a new trait `ProcessRateLimits` to handle rate limit details and retry logic. - Integrated rate limit processing into the `handleRequestException` method for 429 errors. - Enhanced exception handling tests to verify extraction of rate limit details and retry information.
…cessesRateLimits - Renamed the `ProcessRateLimits` trait to `ProcessesRateLimits` for consistency..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds improved handling and extraction of rate limit and retry information from Gemini provider error responses. The main theme is enhancing how rate limit violations are processed and surfaced, especially when a 429 (rate limited) error occurs.
Enhancements to rate limit handling:
ProcessesRateLimitstrait to encapsulate logic for extracting rate limit violations and retry-after information from Gemini API error responses. (src/Providers/Gemini/Concerns/ProcessesRateLimits.php)Geminiprovider to use the newProcessesRateLimitstrait and to throwPrismRateLimitedExceptionwith detailed rate limit and retry-after information when a 429 error is encountered. (src/Providers/Gemini/Gemini.php) [1] [2] [3]Testing improvements:
retry_afterand rate limit details from quota violations in Gemini error responses. (tests/Providers/Gemini/ExceptionHandlingTest.php)