Open
Conversation
carlagn
requested review from
AmanVarshney01,
ArthurGamby,
aidankmcalister,
ankur-arch,
mhartington and
mhessdev
Contributor
WalkthroughThis PR introduces a new Alert component to the Eclipse design system with four semantic variants, integrates it into the documentation site for custom callout rendering, and adds comprehensive documentation with usage examples and accessibility guidance. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Contributor
🍈 Lychee Link Check Report3664 links: ❌ Errors
Full Statistics Table
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/docs/source.config.ts`:
- Around line 66-75: The types mapping has tip set to "info" but the
Callout/docs treat `tip` as `success`; update the `types` object in
apps/docs/source.config.ts so the `tip` key maps to "success" (i.e., change the
`tip: "info"` entry to `tip: "success"`) and verify other callout keys (e.g.,
`danger`, `warn`, `error`) remain consistent with the docs; if the docs are
intended to change instead, update the docs/callout mapping to match the current
`tip: "info"` value instead.
0c9bb4f to
8c606a2
Compare
carlagn
force-pushed
the
feat/DR-7288-alert
branch
from
3f5a5de to
ac772f1
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Update CSP for fontawesome in docs
carlagn
force-pushed
the
feat/DR-7288-alert
branch
from
7899506 to
14998fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation