feat: add FES warning for zero or negative textSize#8655
Open
YuktiNandwana wants to merge 2 commits intoprocessing:mainfrom
Open
feat: add FES warning for zero or negative textSize#8655YuktiNandwana wants to merge 2 commits intoprocessing:mainfrom
YuktiNandwana wants to merge 2 commits intoprocessing:mainfrom
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone!
This PR adds a Friendly Error System (FES) warning when
textSize()is called with a value of0or less.Why this change?
While looking into issue #8649, I noticed that if a user accidentally sets
textSize(0), thetextLeadingalso becomes 0. If this text is constrained by a width, it wraps but draws all lines exactly on top of each other at the same Y-coordinate. This creates a confusing overlapping effect for users.Adding this warning helps beginners quickly realize the typo instead of getting stuck on why their text looks broken.
What was done:
p5.prototype.textSizeinsrc/typography/attributes.js.p5._friendlyErroriftheSize <= 0.I've tested this locally and the FES warning shows up correctly in the console. Let me know if any changes are needed!
Fixes #8649