Skip to content

skip raspi deps/config if not on raspi platform#896

Draft
raul-marquez-csa wants to merge 3 commits intoproject-chip:mainfrom
raul-marquez-csa:non-raspi-install
Draft

skip raspi deps/config if not on raspi platform#896
raul-marquez-csa wants to merge 3 commits intoproject-chip:mainfrom
raul-marquez-csa:non-raspi-install

Conversation

@raul-marquez-csa
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the setup scripts by introducing platform-specific checks. It ensures that Raspberry Pi-specific dependency installations and machine configurations are only applied when the script is executed on a Raspberry Pi, preventing errors or unnecessary operations on other platforms like WSL or generic Ubuntu environments.

Highlights

  • Conditional Script Execution: Raspberry Pi-specific dependency installation and machine configuration steps are now conditionally executed only when detected on a Raspberry Pi, preventing execution on other platforms.
  • WSL Detection: The install-pi-dependencies.sh script now includes logic to detect if it's running in Windows Subsystem for Linux (WSL), allowing it to skip Raspberry Pi-specific steps and provide appropriate messaging.
  • Platform Detection Utilities: New utility functions, is_running_on_raspberry_pi and is_running_in_wsl, were added to scripts/utils.sh to centralize and facilitate platform-specific logic across scripts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • backend
    • Updated the backend submodule to a newer commit.
  • scripts/pi-setup/install-pi-dependencies.sh
    • Added conditional logic to exit early if not running on a Raspberry Pi or if running in WSL.
  • scripts/ubuntu/2-machine-cofiguration.sh
    • Wrapped the WiFi setup (wpa_supplicant service creation and configuration) within a Raspberry Pi detection block.
    • Wrapped WLAN-specific sysctl settings within a Raspberry Pi detection block.
    • Added messages for skipping WiFi configuration when not on a Raspberry Pi or in WSL.
  • scripts/utils.sh
    • Added is_running_on_raspberry_pi function to detect if the script is running on a Raspberry Pi.
    • Added is_running_in_wsl function to detect if the script is running in Windows Subsystem for Linux.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces logic to skip Raspberry Pi-specific dependency installation and configuration when the scripts are not run on a Raspberry Pi platform, making the scripts more robust for different environments like WSL. However, a potential configuration injection vulnerability was identified in scripts/ubuntu/2-machine-cofiguration.sh where the WLAN_INTERFACE environment variable is used unsafely to construct sysctl settings. Additionally, I've provided a couple of suggestions to further refine the new code for better conciseness and maintainability.

@raul-marquez-csa raul-marquez-csa force-pushed the non-raspi-install branch 5 times, most recently from 777ef27 to 79d99f5 Compare February 28, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant