Add join, leave, view room buttons for entries in the SpaceLobby#739
Merged
kevinaboos merged 9 commits intoproject-robius:mainfrom Feb 13, 2026
Merged
Conversation
code needs a bit of cleanup but the main functionality is there. Leaving a space is untested.
They're 90% identical, so there's no point in keeping them separate, especially now that their event handling is almost entirely duplicate.
Make space lobbies easier to ID with a clear `[Space]` prefix in the dock tab name or the stacknav header
Currently, leaving a space will auto-leave ALL rooms within that space. In the future, we need to create a separate modal that allows the user to selectively choose which rooms will be left. I think the best way to do that is a modal that behaves like a file copy dialog when it encounters file naming conflicts, in which you can choose whether to replace or skip each individual file, or you can replace all, or you can replace none. In the same vain, our LeaveSpaceModal should allow interactively staying in or leaving each room, or leaving them all, or staying in all of them.
kevinaboos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also implement joining child spaces, leaving child spaces, and more space-related actions.