Increase default max pid limit#340
Open
haircommander wants to merge 1 commit intoprojectatomic:docker-1.13.1-rhelfrom
Open
Increase default max pid limit#340haircommander wants to merge 1 commit intoprojectatomic:docker-1.13.1-rhelfrom
haircommander wants to merge 1 commit intoprojectatomic:docker-1.13.1-rhelfrom
Conversation
Users were surprised by the suddenly low pid limit on their pods. Change the default to something higher, such as the theoretical maximum number of pids on a 32 bit system. Signed-off-by: Peter Hunt <pehunt@redhat.com>
Member
|
This will allow a couple of pods to cause DOS to other containers on the system. The reason the number was low was to allow lots of containers to run without one container using up all of the pids. |
Author
Member
|
@haircommander Hard to say. |
Author
|
As a user not thinking about this feature, I'd expect my pods to have as many pids as possible. I.E. we should allow them to DOS their system. If they then decide that isn't good, they should change from the default. |
Member
|
@haircommander This feature was demanded by our customers, they wanted to make sure that we picked good defaults. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users were surprised by the suddenly low pid limit on their pods. Change the default to something higher, such as the theoretical maximum number of pids on a 32 bit system.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1696752
Signed-off-by: Peter Hunt pehunt@redhat.com