feat: add support for ssh_endpoint#140
Open
rxbn wants to merge 2 commits intoprojectsyn:masterfrom
Open
Conversation
4 tasks
simu
reviewed
Apr 29, 2026
| local argocd = import 'lib/argocd.libjsonnet'; | ||
|
|
||
| local app = argocd.App('lieutenant', params.namespace); | ||
| local app = argocd.App('lieutenant', params.namespace) { |
Member
There was a problem hiding this comment.
This change has already been merged in #143, can you please drop the commit from this PR?
Comment on lines
+14
to
+19
| local gh = params.githosts[name]; | ||
| { | ||
| endpoint: gh.endpoint, | ||
| token: gh.token, | ||
| hostKeys: gh.host_keys, | ||
| } + if std.objectHas(gh, 'ssh_endpoint') then { sshEndpoint: gh.ssh_endpoint } else {}, |
Member
There was a problem hiding this comment.
I'd probably write this as follows, but no hard feelings either way:
Suggested change
| local gh = params.githosts[name]; | |
| { | |
| endpoint: gh.endpoint, | |
| token: gh.token, | |
| hostKeys: gh.host_keys, | |
| } + if std.objectHas(gh, 'ssh_endpoint') then { sshEndpoint: gh.ssh_endpoint } else {}, | |
| local gh = params.githosts[name]; | |
| { | |
| endpoint: gh.endpoint, | |
| token: gh.token, | |
| hostKeys: gh.host_keys, | |
| [if std.objectHas(gh, 'ssh_endpoint') then 'sshEndpoint']: std.get(gh, ssh_endpoint), | |
| }, |
| githosts: | ||
| your-gitlab: | ||
| endpoint: https://git.yourdomain.net/ | ||
| ssh_endpoint: ssh://gitlab-ssh.yourdomain.net |
Member
There was a problem hiding this comment.
I'd use a callout here for the note below.
Suggested change
| ssh_endpoint: ssh://gitlab-ssh.yourdomain.net | |
| ssh_endpoint: ssh://gitlab-ssh.yourdomain.net <1> |
Comment on lines
37
to
+40
| ---- | ||
|
|
||
| `ssh_endpoint` is optional. If omitted, the operator uses the same host as `endpoint` for SSH. | ||
| Provide a full SSH URL (for example `ssh://gitlab-ssh.example.com`) or just a host name. |
Member
There was a problem hiding this comment.
Suggested change
| ---- | |
| `ssh_endpoint` is optional. If omitted, the operator uses the same host as `endpoint` for SSH. | |
| Provide a full SSH URL (for example `ssh://gitlab-ssh.example.com`) or just a host name. | |
| ---- | |
| <1> `ssh_endpoint` is optional. If omitted, the operator uses the same host as `endpoint` for SSH. | |
| Provide a full SSH URL (for example `ssh://gitlab-ssh.example.com`) or just a host name. |
| githosts: | ||
| your-gitlab: | ||
| endpoint: https://git.yourdomain.net/ | ||
| ssh_endpoint: ssh://gitlab-ssh.yourdomain.net |
Member
There was a problem hiding this comment.
May not be necessary to mention the optional parameter here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.