Merged
Conversation
|
No bump labels present 🛠️ Auto tagging disabled |
simu
changed the title
additional-root-apps
6 tasks
simu
force-pushed
the
feat/additional-root-apps
branch
3 times, most recently
from
c361f3d to
077af4f
Compare
Member
Author
|
See projectsyn/documentation#182 for documentation |
simu
force-pushed
the
feat/additional-root-apps
branch
from
077af4f to
3022570
Compare
DebakelOrakel
approved these changes
Dec 31, 2024
simu
force-pushed
the
feat/additional-root-apps
branch
2 times, most recently
from
20491ad to
8d505f2
Compare
We use `syn-teams.libsonnet` to get the list of non-owner teams for which we need to generate additional root apps in Steward. Please note that this implementation will only create root apps for teams who are assigned to at least one application that's present in the cluster.
simu
force-pushed
the
feat/additional-root-apps
branch
from
8d505f2 to
27647ba
Compare
The list of teams in the config map should never contain the team owning the cluster, since that team keeps the "default" root app named `root` and the default app project named `syn`. Additionally, we don't want to generate a root app and app project for teams which are listed in the parameter but which don't have any component instances assigned. The test case is setup to have a structure in parameter `syn` which covers the cases outlined above. Rendered from template version: main (98d16f)
simu
force-pushed
the
feat/additional-root-apps
branch
from
27647ba to
45f6c10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the component to generate the config map
additional-root-appswhich Steward reads to determine what additional ArgoCD AppProject and Application resources to bootstrap.The config map must always be present, but the value of field
teamscan be an empty JSON list.The list of teams in the config map should never contain the team owning the cluster, since that team keeps the "default" root app named
rootand the default app project namedsyn.Additionally, we don't want to generate a root app and app project for teams which are listed in the parameter but which don't have any component instances assigned.
The full feature requires a version of Steward which includes projectsyn/steward#158
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.