Fix long_running_transactions query (#1066)#1210
Open
moreinhardt wants to merge 1 commit intoprometheus-community:masterfrom
Open
Fix long_running_transactions query (#1066)#1210moreinhardt wants to merge 1 commit intoprometheus-community:masterfrom
moreinhardt wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
Previously the query counted all transactions. Signed-off-by: Moritz Reinhardt <moreinhardt@gmail.com>
Author
|
Not sure how I can make the circleci checks pass? There's some error about a pubkey? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the query counted all transactions.
Without this, the metric doesn't really make any sense.
Tests still pass. The related test actually mocks the return value of the query so it doesn't test the query itself.