Skip to content

ci: fast Java formatting check using google-java-format native binary #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaydeluca merged 1 commit into from
Mar 21, 2026
Merged

ci: fast Java formatting check using google-java-format native binary #1984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/renovate-tracked-deps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@
"lychee",
"node",
"npm:renovate",
"protoc"
"protoc",
"ubi:google/google-java-format"
],
"regex": ["ghcr.io/super-linter/super-linter", "grafana/flint"]
},
Expand Down
21 changes: 14 additions & 7 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ lychee = "0.23.0"
node = "24.14.0"
"npm:renovate" = "43.45.1"
protoc = "34.0"
"ubi:google/google-java-format" = "1.34.1"

[env]
RENOVATE_TRACKED_DEPS_EXCLUDE="github-actions,github-runners"
Expand Down Expand Up @@ -66,23 +67,29 @@ file = "https://raw.githubusercontent.com/grafana/flint/8a39d96e17327c54974623b2
description = "Install native lint tools matching the pinned super-linter version"
file = "https://raw.githubusercontent.com/grafana/flint/8a39d96e17327c54974623b252eb5260d67ed68a/tasks/setup/native-lint-tools.sh" # v0.9.1

[tasks."lint:spotless"]
description = "Check Java formatting with Spotless"
# examples don't have the spotless plugin, so we exclude them via the profile.
# integration-tests are covered by the CI build task.
run = "./mvnw com.diffplug.spotless:spotless-maven-plugin:check -P '!examples-and-integration-tests' -q"
[tasks."lint:java"]
description = "Check Java formatting (changed files only)"
run = """
files=$(git diff --name-only --diff-filter=d origin/main...HEAD -- '*.java')
[ -z "$files" ] && exit 0
google-java-format --dry-run --set-exit-if-changed $files
"""

[tasks."lint:fast"]
description = "Run fast lints (no Renovate)"
depends = ["lint:super-linter", "lint:links", "lint:bom", "lint:example-poms", "lint:spotless"]
depends = ["lint:super-linter", "lint:links", "lint:bom", "lint:example-poms", "lint:java"]

[tasks."lint"]
description = "Run all lints"
depends = ["lint:fast", "lint:renovate-deps"]

[tasks.fix]
description = "Auto-fix lint issues"
run = "AUTOFIX=true mise run lint"
run = """
files=$(git diff --name-only --diff-filter=d origin/main...HEAD -- '*.java')
[ -n "$files" ] && google-java-format -i $files
AUTOFIX=true mise run lint
"""

[tasks.native-lint]
description = "Run lints natively (no container)"
Expand Down
Loading