OM 2.0: MetricFamily name is the same as Metric Name for target_info#2873
Open
dashpole wants to merge 2 commits intoprometheus:mainfrom
Open
OM 2.0: MetricFamily name is the same as Metric Name for target_info#2873dashpole wants to merge 2 commits intoprometheus:mainfrom
dashpole wants to merge 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: David Ashpole <dashpole@google.com>
krajorama
reviewed
Mar 11, 2026
krajorama
previously approved these changes
Mar 11, 2026
Member
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
Approved. I was about to open a PR as well :) One comment
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: David Ashpole <dashpole@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2852
targetis an info metric family name, so it needs to betarget_infoeverywhere.cc @bwplotka @krajorama @ywwg