Skip to content

OM 2.0: cleanup left-over text from when MetricPoints could have multiple values#2874

Merged
dashpole merged 1 commit intoprometheus:mainfrom
dashpole:cleanup_4
Mar 11, 2026
Merged

OM 2.0: cleanup left-over text from when MetricPoints could have multiple values#2874
dashpole merged 1 commit intoprometheus:mainfrom
dashpole:cleanup_4

Conversation

@dashpole
Copy link
Contributor

@dashpole dashpole commented Mar 9, 2026

Counters no longer have a "Total" and a "created" value. Remove references to things being associated with a counter's "Total" sample.

All types now only have a single value per-metricpoint. Remove text about that from types. Clarify that they have Number values.

cc @bwplotka @krajorama @ywwg

krajorama
krajorama previously approved these changes Mar 11, 2026
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I think after this PR and #2875 we should take another pass and see if we have to spell out to put the value of the metric in the line.

bwplotka
bwplotka previously approved these changes Mar 11, 2026
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dashpole dashpole dismissed stale reviews from bwplotka and krajorama via 2957920 March 11, 2026 14:55
Signed-off-by: David Ashpole <dashpole@google.com>
@dashpole
Copy link
Contributor Author

Rebase removed approvals. Merging as the diff is the same.

@dashpole dashpole merged commit 14e26f4 into prometheus:main Mar 11, 2026
6 checks passed
@dashpole dashpole deleted the cleanup_4 branch March 11, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants