fix(om2.0): consistency between text and abnf on Summary fields#2886
Open
fix(om2.0): consistency between text and abnf on Summary fields#2886
Conversation
In #2627 and #2634 we've made the Sum and Count mandatory fields in histograms. They became mandatory in Summary due to the ABNF as that has precedence. This PR changes the data model to follow the ABNF and be consistent with histograms. Note: this is probably the last chance to reverse course and make Sum and/or Count optional without a breaking change. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2627 and #2634 we've made the Sum and Count mandatory fields in histograms. They became mandatory in Summary due to the ABNF as that has precedence.
This PR changes the data model to follow the ABNF and be consistent with histograms.
Note: this is probably the last chance to reverse course and make Sum and/or Count optional without a breaking change.