mountstats/linux: fix multiple transports statistics labeling#3358
mountstats/linux: fix multiple transports statistics labeling#3358SuperQ merged 2 commits intoprometheus:masterfrom
Conversation
|
@discordianfish @SuperQ ping again..... must be a sad joke... |
|
@sagigrimberg Whats the intention? Why do you need individual metrics per transport? Not familiar with nconnect |
|
@discordianfish Sorry for the super long delay - I stopped checking this PR frequently. The intention is to support nconnect mount option in NFS. Which creates multiple connections (transports). Currently any nconnect>1 breaks the exporter. |
When mounting nfs with nconnect, mountstats will show multiple transports. Currently the mountstats exporter fails to create metrics from this information due to repeated entries. Fix this by adding transport metrics a "transport" label enumerating their order in the mountstats output. Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
sagigrimberg
force-pushed
the
sagi/fix-nfs-multi-xprt
branch
from
566270c to
53503f8
Compare
|
@discordianfish @SuperQ ping |
4 similar comments
|
@discordianfish @SuperQ ping |
|
@discordianfish @SuperQ ping |
|
@discordianfish @SuperQ ping |
|
@discordianfish @SuperQ ping |
|
@discordianfish @SuperQ ping |
1 similar comment
|
@discordianfish @SuperQ ping |
|
Thank you. So you will merge this branch? |
|
@discordianfish @SuperQ can this PR be merged please? |
|
@discordianfish @SuperQ ping |
|
@discordianfish @SuperQ ping can we get this merged? |
1 similar comment
|
@discordianfish @SuperQ ping can we get this merged? |
|
@discordianfish @SuperQ ping is there anything I can do to get this merged? |
|
We need this as well, the bug is currently breaking our monitoring setup in production. We rely on the mountstats metrics to track NFS performance indicators. We're using The bug causes excessive log volume from the node-exporter, see #3258. Is there any way to get this merged @discordianfish @SuperQ? In our case the bug was triggered when upgrading from Debian 12 (v1.5.0) to Debian 13 (v1.9.0), I can imagine we're not the only ones experiencing this. |
4 participants
When mounting nfs with nconnect, mountstats will show multiple transports. Currently the mountstats exporter fails to create metrics from this information due to repeated entries.
Fix this by adding transport metrics a "transport" label enumerating their order in the mountstats output.