Conversation
ananthb
force-pushed
the
bcachefs-collector
branch
4 times, most recently
from
239cd90 to
b1d2f00
Compare
Add support for collecting and reporting metrics from bcachefs filesystems. Signed-off-by: Ananth Bhaskararaman <antsub@gmail.com>
ananthb
force-pushed
the
bcachefs-collector
branch
from
b1d2f00 to
bd5c99d
Compare
|
|
||
| bcachefsPath := sysFilePath("fs/bcachefs") | ||
|
|
||
| entries, err := os.ReadDir(bcachefsPath) |
There was a problem hiding this comment.
Thanks, but we prefer to have all proc/sys file parsing in https://github.com/prometheus/procfs.
Maybe this should be added here: https://github.com/prometheus/procfs/tree/master/bcache
There was a problem hiding this comment.
Would it make more sense in a separate bcachefs folder? bcachefs development isn't really tied to bcache anymore.
There was a problem hiding this comment.
It looks like someone did start adding bcachefs support but that has stalled! prometheus/procfs#750
There was a problem hiding this comment.
Uh hah that was me from about six months ago. I'd been meaning to do this for a while, so must have forgotten that one when I started on this two weeks ago.
There was a problem hiding this comment.
I can finish that up with the code from here. I tested this out and it works!
There was a problem hiding this comment.
Yea, a separate package for bcachefs is fine.
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Please move the raw file parsing to https://github.com/prometheus/procfs/tree/master/bcache.
3 participants
Add support for collecting and reporting metrics from bcachefs filesystems.