netlink: add node_network_altnames_info metric#3541
Merged
SuperQ merged 1 commit intoprometheus:masterfrom Feb 11, 2026
Merged
Conversation
Member
|
Maybe #3540 is a better option. |
Contributor
Author
Member
|
I'm not sure how a regexp is required for matching, both are additional labels so they would function the same. |
Contributor
Author
altnames in #3540 is like below. If we need to fetch device of interface with altname2, then we would need to match altnames column with ( Whereas in current PR, we have only 1 altname per row/label. So we can use |
Member
|
Ahh, yes, if there are multiple altnames this makes a lot of sense. |
SuperQ
requested changes
Feb 10, 2026
Signed-off-by: Anvesh J <ajaggapa@redhat.com>
3de0efa to
06b3a6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a mapping for altnames and device names with new
node_network_altnames_infoThis will be used to fetch any other metrics that have only device name label but not altname.