fix(deps): move optional onnx extra to 1.21.0rc3 for CVE-2026-28500 mitigation#726
Conversation
…itigation Co-authored-by: Codex <noreply@openai.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request bumps the optional ONNX requirement to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 67: Replace the RC dependency pin in the onnx entries so they target the
stable 1.21.0 release (e.g., change the dependency declared as "onnx =
[\"onnx>=1.21.0rc3,<2.0; python_version < '3.13'\"]" to require the stable
1.21.0 instead) or, if you must keep the RC temporarily, add an inline comment
next to each "onnx = ..." entry documenting the RC risk window and that
CVE-2026-28500 relates to onnx.hub which this codebase does not use (we only use
onnx.load, onnx.mapping, onnx.helper, onnx.numpy_helper, onnx.TensorProto);
update all four occurrences to be consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f50f0d9f-01f7-4751-985b-7a5846e04dad
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
CHANGELOG.mdpyproject.toml
Document why the optional ONNX extra is using an RC temporarily: the advisory is specific to onnx.hub.load(), which ModelAudit does not call. Co-authored-by: Codex <noreply@openai.com>
…ve-2026-28500 Co-authored-by: Codex <noreply@openai.com>
Summary
onnx.hubis no longer present in the resolved package, removing the vulnerable API flagged by CVE-2026-28500QA
uv lock --checkuv sync --extra all-ciuv run --extra onnx pytest tests/scanners/test_onnx_scanner.py tests/scanners/test_onnx_dependency_handling.py -quv run ruff check modelaudit/ tests/uv run ruff format --check modelaudit/ tests/uv run mypy modelaudit/uv run pytest -n auto -m "not slow and not integration" --maxfail=1Note
This uses an ONNX release candidate because the advisory currently lists no patched stable release for
<=1.20.1.Summary by CodeRabbit