feat: add default modules and configurations for sequencer presets#398
feat: add default modules and configurations for sequencer presets#3984 commits merged intodevelopfrom
Conversation
| graphiqlEnabled: true, | ||
| }; | ||
| export const developmentConfig = { | ||
| proofsEnabled: false, |
There was a problem hiding this comment.
I really don't like that we are redefining all these configuration options here. Because we already have them defined on a module level - ConfigurableModule allows us to extract config typing.
I would queue a followup PR where we try to remove this middle layer and reuse the config types directly. Obviously we need some translation layer from ENV variables -> configs - we can think about how to best do this.
We should also separate clearly between mandatory configs, which we have to set in the starter kit (things like ports, connection strings, etc. - these will mostly be env variables as well) and then non-mandatory configuration, of which we have a quite a few as well, but which aren't included in here at all yet - that's where reusing the module's config types comes in handy
Summary
This PR introduces new classes in the
stackpackage that provide ready-to-use defaults for modules and configuration.What’s Included
Default Modules & Configs
DefaultModulesandDefaultConfigsGoal
The goal of this change is to: