Skip to content

Delayed dependency factory usage to after registration #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpanic wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Delayed dependency factory usage to after registration #477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0fd37
Delayed dependency factory usage to after registration of all depende…
rpanic Mar 26, 2026
5c74b7e
Fixed function this reference issue
rpanic Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions packages/common/src/config/ModuleContainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,12 @@ export class ModuleContainer<Modules extends ModulesRecord>
return Object.prototype.hasOwnProperty.call(modules, moduleName);
}

private isValidModuleNameTuple(
module: [string, BaseModuleType]
): module is [StringKeyOf<Modules>, BaseModuleType] {
return Object.prototype.hasOwnProperty.call(this.definition, module[0]);
}

public assertContainerInitialized(
container: DependencyContainer | undefined
): asserts container is DependencyContainer {
Expand All @@ -246,26 +252,26 @@ export class ModuleContainer<Modules extends ModulesRecord>
* @param modules
*/
protected registerModules(modules: Modules) {
Object.keys(modules).forEach((moduleName) => {
if (Object.prototype.hasOwnProperty.call(modules, moduleName)) {
this.assertIsValidModuleName(moduleName);

log.debug(`Registering module: ${moduleName}`);
const moduleClasses = Object.entries(modules).filter(
this.isValidModuleNameTuple.bind(this)
);

const useClass = modules[moduleName];
moduleClasses.forEach(([moduleName, useClass]) => {
log.debug(`Registering module: ${moduleName}`);

this.container.register(
moduleName,
{ useClass },
{ lifecycle: Lifecycle.ContainerScoped }
);
this.onAfterModuleResolution(moduleName);
this.container.register(
moduleName,
{ useClass },
{ lifecycle: Lifecycle.ContainerScoped }
);
this.onAfterModuleResolution(moduleName);

this.registerAliases(moduleName, useClass);
this.registerAliases(moduleName, useClass);
});

if (this.isDependencyFactory(useClass)) {
this.useDependencyFactory(useClass, moduleName);
}
moduleClasses.forEach(([moduleName, clazz]) => {
if (this.isDependencyFactory(clazz)) {
this.useDependencyFactory(clazz, moduleName);
}
});
}
Expand Down
Loading