Skip to content

Еремин Даниил#36

Open
18thday wants to merge 66 commits intopsds-cpp:mainfrom
RIZONTE:main
Open

Еремин Даниил#36
18thday wants to merge 66 commits intopsds-cpp:mainfrom
RIZONTE:main

Conversation

@18thday
Copy link
Contributor

@18thday 18thday commented Jan 16, 2026

No description provided.

RIZONTE and others added 30 commits November 24, 2025 09:53
}
if(size_ != 1){
begin_ = begin_ + 1 == data_.end() ? data_.begin() + 1 : begin_ + 1;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

часть кода можно не копироватьесли использовать TryPush

}
if(size_ != 1){
begin_ = begin_ + 1 == data_.end() ? data_.begin() + 1 : begin_ + 1;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как-то сложно получилось из-за необходимости постояннодобавлять вычитать 1

New.insert(New.begin(), 0);
New.resize(size + 1);
data_ = New;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

сложная реализация

Copy link
Contributor Author

@18thday 18thday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RIZONTE следующие моменты:

  • местами много лишних комментариев декларирующих то что понятно из кода
  • дублирование кода
  • UB const_cast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants