[PULP-817] Django5 support and adjustments to make imp/exp work with django-imp-exp 4.x. #7290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
backport-6973-3.63
branch
6 times, most recently
from
9aabfb2 to
73c2bb7
Compare
gerrod3
force-pushed
the
backport-6973-3.63
branch
4 times, most recently
from
b6ec2a1 to
beb5431
Compare
dralley
requested changes
Feb 8, 2026
Contributor
dralley
left a comment
dralley
left a comment
There was a problem hiding this comment.
Needs a changelog to note that this is a breaking change w/r/t exports created before and after the Django Import/Export upgrade (if it is upgraded)
Contributor
|
Also we need to document somehow that the Postgresql requirement changes for Django 5 |
…django-imp-exp 4.x. Co-authored-by: David Davis <daviddavis@users.noreply.github.com> Assisted by: cursor agent Co-authored-by: Cursor <cursoragent@cursor.com>
gerrod3
force-pushed
the
backport-6973-3.63
branch
from
beb5431 to
4a97238
Compare
dralley
reviewed
Feb 10, 2026
| """Verify that the deletion of artifacts is prohibited for both regular users and | ||
| administrators.""" | ||
| if settings.DEFAULT_FILE_STORAGE != "pulpcore.app.models.storage.FileSystem": | ||
| if pulp_settings.STORAGES["default"]["BACKEND"] != "pulpcore.app.models.storage.FileSystem": |
Contributor
There was a problem hiding this comment.
This doesn't break if it's used with Django 4 though , right?
Contributor
There was a problem hiding this comment.
Never mind, I see the "compatibility layer"
dralley
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 793c0ad)
closes #5324.
closes #6988.
Assisted by: cursor agent
📜 Checklist
See: Pull Request Walkthrough