Skip to content

Add support for Ubuntu 24.04#2585

Open
fetzerms wants to merge 3 commits intopuppetlabs:mainfrom
fetzerms:ubuntu24.04
Open

Add support for Ubuntu 24.04#2585
fetzerms wants to merge 3 commits intopuppetlabs:mainfrom
fetzerms:ubuntu24.04

Conversation

@fetzerms
Copy link
Copy Markdown

Summary

This adds support for Ubuntu 24.04

Additional Context

n/a

Related Issues (if any)

I see #2577 which did not add the acceptance tests nor the determination of the according php version.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@fetzerms fetzerms requested review from a team, bastelfreak, ekohl and smortex as code owners December 30, 2024 14:53
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 30, 2024

CLA assistant check
All committers have signed the CLA.

@fetzerms fetzerms changed the title Ubuntu24.04 Add support for Ubuntu 24.04 Dec 30, 2024
@bastelfreak
Copy link
Copy Markdown
Collaborator

The used facterdb version has no factsets for Ubuntu 24.04. That means that no unit tests will test Ubuntu 24.04. I highly recommend to update to a newer FacterDB version first.

@chrisongthb
Copy link
Copy Markdown
Contributor

Any news here? We also need adoptions for 24.04 auth_kerb apt package name.

@ekohl
Copy link
Copy Markdown
Collaborator

ekohl commented Mar 5, 2025

The used facterdb version has no factsets for Ubuntu 24.04. That means that no unit tests will test Ubuntu 24.04. I highly recommend to update to a newer FacterDB version first.

A new facterdb version with 24.04 facts was released so that should be resolved now

Any news here? We also need adoptions for 24.04 auth_kerb apt package name.

That isn't mentioned in this PR. Could you explain what actually changed and what code changes are expected?

@chrisongthb
Copy link
Copy Markdown
Contributor

A new facterdb version with 24.04 facts was released so that should be resolved now

Can I contribute via this fork here or would I have to create a new one?

That isn't mentioned in this PR. Could you explain what actually changed and what code changes are expected?

With Ubuntu 24.04 the package libapache2-mod-auth-kerb is no longer present. Thus, we have to move to gssapi module. Maybe we could adopt params.pp?

@bastelfreak
Copy link
Copy Markdown
Collaborator

Can I contribute via this fork here or would I have to create a new one?

it's not that easy. Perforce pins to an ancient FacterDB version in this module: https://github.com/puppetlabs/puppetlabs-apache/blob/main/Gemfile#L25.

This is based on a template from https://github.com/puppetlabs/pdk-templates/blob/main/config_defaults.yml.

And that got recently updated to allow FacterDB 3.X: puppetlabs/pdk-templates@d37befc.

I do not know what the desired workflow is to roll out those changes to modules.

@meltingrobot
Copy link
Copy Markdown

What is needed to get Ubuntu 24.04 support going for this module?

@mxr0
Copy link
Copy Markdown

mxr0 commented Dec 29, 2025

@bastelfreak could you pleases Merge one of the Following changes?
I really don't care which one, the all have the important bits, but the one on top seems to be most complete.

#2585
#2618
#2575
#2577
#2619

Ubuntu 24.04 Support should really be available (now that 26.04 is around the corner).
Very much appreciated.
Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants