feat(apache::vhost): refactor ModSecurity configuration handling#2627
Open
bovy89 wants to merge 1 commit intopuppetlabs:mainfrom
Open
feat(apache::vhost): refactor ModSecurity configuration handling#2627bovy89 wants to merge 1 commit intopuppetlabs:mainfrom
bovy89 wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
bovy89
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
bovy89
force-pushed
the
main
branch
3 times, most recently
from
6f8403c to
96668e7
Compare
bovy89
force-pushed
the
main
branch
6 times, most recently
from
c4cd14d to
3fa7900
Compare
- Add modsec_rule_engine parameter (Enum['On','Off','DetectionOnly'], default 'On') to explicitly control SecRuleEngine directive - Deprecate modsec_disable_vhost boolean in favor of modsec_rule_engine (retain backward compatibility via deprecation warning) - Security fragment template is now always included (as before) - Add EPP signature with explicit type enforcement to _security.epp - Guard all non-engine directives in _security.epp behind modsec_rule_engine != 'Off' to prevent inert configuration noise when ModSecurity is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)