Fix purs graph command after bundling/running single package in monorepo#1394
Merged
Fix purs graph command after bundling/running single package in monorepo#1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the scenario where one has:
.spagodirectory (so all dependencies need to be installed)package-aimports a subset of the total dependencies..then running
spago bundle -p package-aorspago run -p package-awill fail with a mysteriouspurs grapherror.That's due to the fact that we (mistakenly) included the complete set of dependencies when running the graph check, which would fail since not all dependencies were installed.
spago buildis immune to this, and we lift the fix from there, reusing the same logic.We also add a test to try to prevent this in the future.