Add user authentication and the possibility to trigger/send a message…

[andersonrocha0]

What does this PR do?

Add the authenticate_user method allowing clients to authenticate users.
Add the send_to_user_method allowing any backend to send messages to a specific user.

• If you have changed dependencies, ensure both requirements.txt and setup.py have been updated

CHANGELOG

• [ADDED] authenticate_user method
• [ADDED] send_to_user method

[benjamin-tang-pusher]

When I call
channels_client.send_to_user("123", "user-event", {"message": "hello worlds"})
I get this error (although the message goes through to my client)

File "/Users/benjamintang/development/python/channels/app.py", line 124, in send_to_user
channels_client.send_to_user("123", "user-event", {"message": "hello worlds"})
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/benjamintang/development/python/channels/venv/lib/python3.11/site-packages/pusher/pusher.py", line 151, in send_to_user
return self._pusher_client.send_to_user(user_id, event_name, data)
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/benjamintang/development/python/channels/venv/lib/python3.11/site-packages/pusher/http.py", line 31, in __call__
return self.client.http.send_request(self.make_request(*args, **kwargs))
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/benjamintang/development/python/channels/venv/lib/python3.11/site-packages/pusher/requests.py", line 39, in send_request
        self.session = requests.Session()
 
 
    def send_request(self, request):
        resp = self.session.request(
            request.method,
            ^^^^^^^^^^^^^^
            request.url,
            headers=request.headers,
            data=request.body,
            timeout=self.client.timeout,
            **self.options)
AttributeError: 'dict' object has no attribute 'method'

Do you not get this too? It's odd, as the trigger() method should put POST as the argument, so I'm not sure where its going missing.

@andersonrocha0

[andersonrocha0]

@benjamin-tang-pusher Yes, you are right.

I found the problem and fixed it.

The @request_method is unnecessary because the send_to_user is only a wrapper calling the trigger.

Now, the code is fixed and working.

Please let me know if you have any other problems.

:)

[benjamin-tang-pusher]

Whoops, I forgot about that decorator. I gave it another test and it works now.

I will ask the team to review it.

[andersonrocha0]

@fbenevides do you have any news?

Thx.

[amplicity]

+1, need this

[andersonrocha0]

Any news here?

[alexanderlukens]

@fbenevides any updates on this PR? Would be super helpful to have 😄

[andersonrocha0]

@amad @robertoles @benjamin-tang-pusher @benw-pusher I'm tagging you because you were the last committers on this project. Do you have any intention to finish this PR?

Thanks for any help you can give me.

:)

[evgeniibreikin]

@andersonrocha0 Hey! Pusher team is here, we back!
Thanks a lot for your PR! I've added e few notes around your PR

[andersonrocha0]

@evgeniibreikin I reviewed your comments and fixed some ones of them. Could you please double-check?

Thx.

[evgeniibreikin]

@evgeniibreikin I reviewed your comments and fixed some ones of them. Could you please double-check?

Thx.

@andersonrocha0

Thanks for changes! Last thing I wanna ask you is in my changes request. The reason is: channel name starting with # is incorrect, and the only correct option when you send it to user with prefix #server-to-user-
Imao, it is not clear in pusher.com documentation, will fix it later

[gvso]

@evgeniibreikin I reviewed your comments and fixed some ones of them. Could you please double-check?
Thx.

@andersonrocha0

Thanks for changes! Last thing I wanna ask you is in my changes request. The reason is: channel name starting with # is incorrect, and the only correct option when you send it to user with prefix #server-to-user- Imao, it is not clear in pusher.com documentation, will fix it later

I'd like this to be merged and release. Is removing the expectation of the '#' as a prefix the only thing missing?

[evgeniibreikin]

@evgeniibreikin I reviewed your comments and fixed some ones of them. Could you please double-check?
Thx.

@andersonrocha0
Thanks for changes! Last thing I wanna ask you is in my changes request. The reason is: channel name starting with # is incorrect, and the only correct option when you send it to user with prefix #server-to-user- Imao, it is not clear in pusher.com documentation, will fix it later

I'd like this to be merged and release. Is removing the expectation of the '#' as a prefix the only thing missing?

Yes, everything from changes request. Btw, you can clone this branch locally and use it instead of pip package version

[andersonrocha0]

@evgeniibreikin and @gvso every suggestion was applied and squashed into one commit. Please, double check it.

[evgeniibreikin]

@andersonrocha0 thanks a lot for your contribution! It took a long run to make this merged by the pusher team :):