fix: Add missed events when removing listeners#157
Closed
cwrllab wants to merge 2 commits intopusher:masterfrom
Closed
fix: Add missed events when removing listeners#157cwrllab wants to merge 2 commits intopusher:masterfrom
cwrllab wants to merge 2 commits intopusher:masterfrom
Conversation
Author
|
@fbenevides @benw-pusher |
Keith-wright
pushed a commit
that referenced
this pull request
Mar 16, 2026
PusherChannel.trigger() now accepts an event without channelName, defaulting to the channel's own name, aligning with the documented API. removeAllListeners() now correctly removes all 7 event listeners; ON_CONNECTION_STATE_CHANGE and ON_SUBSCRIPTION_ERROR were previously not cleared on init() and reset() calls, causing stale listeners to accumulate. Adds an initial Jest test suite covering both fixes. Supersedes #23, #157. Closes #167, #182.
Contributor
|
Closing as the fix proposed here has been incorporated into #188, which was merged with full test coverage. Thanks for the original contribution @changwoolab! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
removeAllListenersdoes not currently remove all listeners.Added missed event types when removing listeners
CHANGELOG
fix: add missed events when removing listeners