feat: consolidate community contributions for host/port config and Android trigger fix#196
Open
Keith-wright wants to merge 1 commit intomasterfrom
Open
feat: consolidate community contributions for host/port config and Android trigger fix#196Keith-wright wants to merge 1 commit intomasterfrom
Keith-wright wants to merge 1 commit intomasterfrom
Conversation
…droid trigger fix - Add host, wsPort, wssPort options to init() for Android and iOS - Make cluster optional to support host-based configurations - Fix ReadableNativeMap cast error on Android trigger() with object data - Fix decodedData variable scoping in event handler - Update README with new config options and fix typos - Update example app with optional host/wsPort/wssPort input fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host,wsPort, andwssPortconfiguration options toinit(), exposed on both Android and iOS (iOS already handles these natively via the Swift SDK's generic options dictionary)ReadableNativeMap cannot be cast to java.lang.Stringcrash on Android when callingtrigger()with object data — serializes to JSON before passing to the native layerclusteroptional ininit()to support host-based configurations that don't require a clusterdecodedDatavariable scoping in the event handlerhost,wsPort, andwssPortinput fieldsCredits
Based on community contributions by:
Closes #100, #147, #158, #161, #165, #180