-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adds faiman_rad and ross models to get_cell_temperature(). #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+86
−11
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
4143e2a
Adds faiman_rad and ross models to get_cell_temperature().
ramaroesilva 70bb948
Addresses flake8 formatting issues.
ramaroesilva acc43b4
Updates contribution md file.
ramaroesilva 69c7f43
Adds test for ross option, placeholder for faiman_rad.
ramaroesilva 5998725
Corrects flake8 issues.
ramaroesilva 61e8163
Adds missing wind_speed=None when testing get_cell_temperature for ross.
ramaroesilva 22f94a7
Corrects wrong function naming.
ramaroesilva aaa52e3
Adds missing input to functions within tests.
ramaroesilva c6d8ab9
Corrects test + flake8 issue.
ramaroesilva 78eb4c3
Minor update in documentation + flake8 issue.
ramaroesilva 402b53c
Another flake8 issue handled.
ramaroesilva 9461e01
Improve faiman_rad test and completes get_cell_temperature doc.
ramaroesilva 9035066
Addresses flake8.
ramaroesilva 6f5bc0d
Update whatsnew doc.
ramaroesilva a536cb2
Defines ir_down as weather variable Within faiman_rad.
ramaroesilva bc62578
Handles flake8 issues.
ramaroesilva 7612e56
Corrects bug in test.
ramaroesilva 534e2f6
Handles flake8.
ramaroesilva f457315
Merge branch 'main' of https://github.com/pvlib/pvlib-python into pvs…
cwhanse 628c15b
move whatsnew note
cwhanse 747f7b9
undo edit to v0.14.0.rst
cwhanse 080a84b
Apply suggestions from code review
cwhanse d55cf78
replace ir_down with longwave_down
cwhanse 1398207
finish replacing ir_down with longwave_down
cwhanse 72b9839
undo edits to temperature.py
cwhanse d9a808d
temperature.faiman_rad doesn't use longwave_down yet
cwhanse 82fa503
Apply suggestions from code review
cwhanse 12e27ff
Update tests/test_pvsystem.py
cwhanse 52f3c57
Merge branch 'main' of https://github.com/pvlib/pvlib-python into pvs…
cwhanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future PRs, we will try to use superscripts instead (that would require other consistency changes in this file, it would be scope creep for this PR). Just letting you know in case you may want to pursue it.
#2205 & #2519