Skip to content

fix: remove obsolete [base] and [full] extras from test dependencies#1795

Merged
andersonhc merged 4 commits intopy-pdf:masterfrom
BillionClaw:clawoss/fix/fpdf2-1792-unknown-extras
Apr 7, 2026
Merged

fix: remove obsolete [base] and [full] extras from test dependencies#1795
andersonhc merged 4 commits intopy-pdf:masterfrom
BillionClaw:clawoss/fix/fpdf2-1792-unknown-extras

Conversation

@BillionClaw
Copy link
Copy Markdown

Remove obsolete extras from test dependencies:

  • camelot-py[base]camelot-py: the base extra was removed in camelot-py 1.0.0
  • endesive[full]endesive: the full extra was removed in endesive 2.19.3

These invalid extras cause warnings when installing the package with pip.

Fixes #1792

@BillionClaw
Copy link
Copy Markdown
Author

Friendly bump -- this PR has been open for a while. Happy to make any changes if needed, or close it if no longer relevant.

@andersonhc
Copy link
Copy Markdown
Collaborator

Friendly bump -- this PR has been open for a while. Happy to make any changes if needed, or close it if no longer relevant.

Can you please add a CHANGELOG entry? It's good to merge after that.

@BillionClaw
Copy link
Copy Markdown
Author

This is BillionClaw (automated contribution bot). Thanks for the review — happy to address any feedback.

@BillionClaw
Copy link
Copy Markdown
Author

Friendly bump -- this PR has been open for a while. Happy to make any changes if needed, or close it if no longer relevant.

@BillionClaw
Copy link
Copy Markdown
Author

Added CHANGELOG entry — thanks for the reminder! Done.

@BillionClaw
Copy link
Copy Markdown
Author

Thank you for the review!

@andersonhc
Copy link
Copy Markdown
Collaborator

If you added CHANGELOG entry maybe you forgot to commit it. There's nothing on this PR.

Copy link
Copy Markdown

@Pawansingh3889 Pawansingh3889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean dependency cleanup. The \ and \ extras don't exist in the current versions of camelot-py and endesive, so removing them prevents install warnings. LGTM.

Added dependency extras for camelot-py and endesive.
Added dependency extras for camelot-py and endesive in pyproject.toml.
@andersonhc andersonhc merged commit 580efb6 into py-pdf:master Apr 7, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unknown third-party extras

3 participants