Fix: bump_dependency now explicitely update all occurrences#14546
Merged
Fix: bump_dependency now explicitely update all occurrences#14546
Conversation
DarkaMaul
changed the title
alex
approved these changes
Mar 26, 2026
Member
|
@DarkaMaul oops, I think there's a regression here: https://github.com/pyca/cryptography/actions/runs/23589119353/job/68689589216 can you take a look? |
DarkaMaul
added a commit
to trail-of-forks/cryptography
that referenced
this pull request
Mar 26, 2026
DarkaMaul
added a commit
to trail-of-forks/cryptography
that referenced
this pull request
Mar 26, 2026
DarkaMaul
added a commit
to trail-of-forks/cryptography
that referenced
this pull request
Mar 26, 2026
alex
pushed a commit
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #14541.
The
bump_dependency.pyscript accidentally updated all matching versions, but only in the case where the first occurrence needed to be updated.The new version searches for all occurrences of the pattern, and updates if there is at least one version number that needs to be bumped.
Note: I tried another approach to define the version number once, but we can't use env variables in matrices, so we would have to use a YAML anchor for this... And I believe we should avoid YAML anchors, if strictly not needed.