fix: Finish deprecation of unset asyncio_default_fixture_loop_scope#1381
Open
JiwaniZakir wants to merge 1 commit intopytest-dev:mainfrom
Open
fix: Finish deprecation of unset asyncio_default_fixture_loop_scope#1381JiwaniZakir wants to merge 1 commit intopytest-dev:mainfrom
JiwaniZakir wants to merge 1 commit intopytest-dev:mainfrom
Conversation
Default asyncio_default_fixture_loop_scope to "function" instead of None and remove the deprecation warning emitted when the option was unset. Closes pytest-dev#924
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
==========================================
+ Coverage 93.64% 94.08% +0.44%
==========================================
Files 2 2
Lines 409 406 -3
Branches 44 43 -1
==========================================
- Hits 383 382 -1
+ Misses 20 19 -1
+ Partials 6 5 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
This is an automated Codecov report, not a human comment -- no response needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #924
Completes the deprecation of the unset
asyncio_default_fixture_loop_scopeconfiguration option. The deprecation warning introduced in a prior release was the interim step; the final behavior is to default the fixture loop scope to"function"rather than requiring users to set it explicitly. Changesdefault=Nonetodefault="function"inpytest_addoptionand removes the_DEFAULT_FIXTURE_LOOP_SCOPE_UNSETwarning string and its associatedwarnings.warncall frompytest_configureinpytest_asyncio/plugin.py. Verified by confirming no warning is emitted whenasyncio_default_fixture_loop_scopeis unset and that fixture loop scope behavior matches the"function"default.