Add test for unserializable marker arguments#14133
Closed
Vivansh27 wants to merge 2 commits intopytest-dev:mainfrom
Closed
Add test for unserializable marker arguments#14133Vivansh27 wants to merge 2 commits intopytest-dev:mainfrom
Vivansh27 wants to merge 2 commits intopytest-dev:mainfrom
Conversation
Update foo function to raise NotImplementedError and add test for unserializable argument.
for more information, see https://pre-commit.ci
|
|
||
|
|
||
| def test_marker_rejects_unserializable_argument(): | ||
| with pytest.raises(TypeError): |
Member
There was a problem hiding this comment.
We should match the error message to be specific enough
Member
|
There is no such requirement AFAIK. Indeed your test actually fails... |
Author
Thanks for pointing that out. My understanding was that this case should return an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test that documents the existing behavior when a pytest
marker receives an unsupported (unserializable) argument type.
No behavior is changed; the test simply ensures a TypeError is raised
to help prevent regressions.