Update database models for new requirements#28
Draft
ChrisLovering wants to merge 11 commits intomainfrom
Draft
Conversation
ChrisLovering
force-pushed
the
Update-database-models-for-new-requirements
branch
2 times, most recently
from
844d54d to
488f915
Compare
ChrisLovering
force-pushed
the
Update-database-models-for-new-requirements
branch
4 times, most recently
from
94639f6 to
d660916
Compare
ChrisLovering
force-pushed
the
Update-database-models-for-new-requirements
branch
2 times, most recently
from
3b3a862 to
9f236be
Compare
This is to indicate that they purely exist for backwards compatibility
This also updates isort config to tell it that alembic is a 3rd party dep.
ChrisLovering
force-pushed
the
Update-database-models-for-new-requirements
branch
from
9f236be to
bec6ede
Compare
D0rs4n
reviewed
Jul 1, 2023
| discord_channel_id: Mapped[int] = mapped_column(BigInteger) | ||
|
|
||
| winner: Mapped[bool] = mapped_column(Boolean, nullable=True) | ||
| first_place_winner: Mapped[bool] = mapped_column(Boolean, nullable=True) |
Member
There was a problem hiding this comment.
I've been meaning to point this out, but previously we were in a hurry, but perhaps, for statistics, it'd be more beneficial to store the placement rather than whether they were placed first or not.
Comment on lines
+17
to
+19
| jam_id: Mapped[int] = mapped_column(primary_key=True) | ||
| name: Mapped[str] = mapped_column(String(), nullable=False) | ||
| ongoing: Mapped[bool] = mapped_column(Boolean, nullable=False, default=False) |
Member
There was a problem hiding this comment.
Tiny addition, we'll need a form_id field, which will be passed to the Discord command as an argument, when creating a new Jam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have done nothing to make these models actually work, this PR is purely for sharing their current state.