Skip to content

fix: Updated default status codes #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NaqGuug wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Updated default status codes #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scim2_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class SCIMClient:
"""

CREATION_RESPONSE_STATUS_CODES: list[int] = [
200,
201,
409,
307,
Expand Down Expand Up @@ -136,6 +137,7 @@ class SCIMClient:

REPLACEMENT_RESPONSE_STATUS_CODES: list[int] = [
200,
201,
307,
308,
400,
Expand Down
26 changes: 0 additions & 26 deletions tests/test_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,32 +204,6 @@ def test_conflict(httpserver, sync_client):
)


def test_no_200(httpserver, sync_client):
"""User creation object should return 201 codes and no 200."""
httpserver.expect_request("/Users", method="POST").respond_with_json(
{
"schemas": ["urn:ietf:params:scim:schemas:core:2.0:User"],
"id": "2819c223-7f76-453a-919d-413861904646",
"userName": "bjensen@example.com",
"meta": {
"resourceType": "User",
"created": "2010-01-23T04:56:22Z",
"lastModified": "2011-05-13T04:42:34Z",
"version": 'W\\/"3694e05e9dff590"',
"location": "https://example.com/v2/Users/2819c223-7f76-453a-919d-413861904646",
},
},
status=200,
)

user_request = User(user_name="bjensen@example.com")

with pytest.raises(UnexpectedStatusCode):
sync_client.create(user_request)
sync_client.create(user_request, expected_status_codes=None)
sync_client.create(user_request, expected_status_codes=[200, 201])


@pytest.mark.parametrize("code", [400, 401, 403, 404, 500])
def test_errors(httpserver, code, sync_client):
"""Test error cases defined in RFC7644."""
Expand Down
Loading