docs: expand run_process Ctrl+C note#3425
docs: expand run_process Ctrl+C note#3425nightcityblade wants to merge 1 commit intopython-trio:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3425 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19424 19418 -6
Branches 1318 1318
===============================================
- Hits 19424 19418 -6
🚀 New features to boost your workflow:
|
A5rocks
left a comment
There was a problem hiding this comment.
Sorry, I don't see how this would have helped the initial issue. The only route to get the error in the issue (that I can think of) is:
- spawn a subprocess (which is in a different process group)
- process uses
tcsetpgrpon that new process group
Or alternatively, a subprocess does a similar dance. This documentation... doesn't really help. Honestly I'm not sure what would help with the issue.
Anyways, it seems you have been opening too many PRs recently... 68 in the last 2 weeks! Unfortunately I think the open issues on Trio need a bunch of thought to how to solve them, so I'm going to close this. Feel free to reopen it whenever you've slowed down how many PRs you make!
Fixes #3300
Expands the
run_processdocs to mention foreground/background process-group behavior on Unix and points readers tostart_new_session=Trueandprocess_group=0when they need isolation from terminal job control.