Closed
Conversation
houndci-bot
reviewed
Mar 17, 2026
| def create_completion(result): | ||
| try: | ||
| if include_data: | ||
| if opcode.type == Create2.type or opcode.type == CreateContainer.type or opcode.type == CreateTTL.type: |
There was a problem hiding this comment.
line too long (119 > 79 characters)
|
|
||
| @classmethod | ||
| def deserialize(cls, bytes, offset): | ||
| return None |
There was a problem hiding this comment.
indentation is not a multiple of four
over-indented
| while not header.done: | ||
| if header.type == Create.type: | ||
| response, offset = read_string(bytes, offset) | ||
| elif header.type in (Create2.type, CreateContainer.type, CreateTTL.type): |
There was a problem hiding this comment.
line too long (85 > 79 characters)
| def children_count(self): | ||
| return self.numChildren | ||
|
|
||
| class AddWatchMode(object): |
| from kazoo.security import OPEN_ACL_UNSAFE | ||
|
|
||
| op = _create_opcode( | ||
| "/test", b"data", OPEN_ACL_UNSAFE, "", False, False, False, False, 1000 |
There was a problem hiding this comment.
line too long (83 > 79 characters)
| from kazoo.security import OPEN_ACL_UNSAFE | ||
|
|
||
| op = _create_opcode( | ||
| "/test", b"data", OPEN_ACL_UNSAFE, "", False, False, False, False, 0 |
There was a problem hiding this comment.
line too long (80 > 79 characters)
| from kazoo.protocol.connection import _CONNECTION_DROP | ||
| from kazoo.protocol.states import KeeperState, KazooState | ||
| from kazoo.tests.util import CI_ZK_VERSION | ||
| from kazoo.protocol.states import ( |
There was a problem hiding this comment.
redefinition of unused 'KazooState' from line 28
redefinition of unused 'KeeperState' from line 28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ttl nodes