Merged
Conversation
StanFromIreland
approved these changes
Mar 16, 2026
| seen_dirs.add(dir_name) | ||
| wildcard = os.path.join(base, dir_name, '*.rst') | ||
| for entry in glob.glob(wildcard): | ||
| if not entry.endswith('/README.rst'): |
Member
There was a problem hiding this comment.
Hmm won't this fail on Windows? But this is a prexisting issue.
Member
Author
There was a problem hiding this comment.
Yeah, I saw that too but kept this PR focused. And this function is only called by the release process, which only supports Linux and macOS, which is enough for all the RMs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changelog entries at https://docs.python.org/3.15/whatsnew/changelog.html have their sections in this order:
Which is case-sensitive reverse alphabetical.
Prior to 3.14.0a1, they were in the order of the blurb template, which is sort of most important first:
This bug was introduced by the use of sets and a final global reverse sort in python/core-workflow#499.
Fix by
Thanks to @mcepl for reporting this at https://discuss.python.org/t/python-3-15-0-alpha-7/106475/2.