gh-140131: Fix REPL cursor position on Windows when module completion suggestion line hits console width #140333
+53
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… line hits console width
…ed px_pos variable" This reverts commit 742096d.
tanloong
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
This reverts commit bb87563.
Contributor
Author
|
@chris-eibl I've added tests for this. |
Member
|
Lgtm. Since this also solves #144259, can you add a second blurb? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips handling the wrapping in
self.__write_changed_line()whenwlen(newline)==self.width, and simply updates self.posxy (explained in #140131 (comment)).One thing that happens after the skip is that the cursor moves leftward by one character on Tab key:
WindowsTerminal_eDpHfMhTvA.mp4
As noted in this comment, "when writing to the final character on the line, the cursor location is effectively moved one element backwards." So, we account for this 1-character offset by setting the cursor column to a maximum of self.width-1.
WindowsTerminal_0fSumUhJoh.mp4