Skip to content

gh-74955: Document that __all__ must contain strings in normalization form NFKC#144504

Merged
serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka:docs-all-non-ascii
Feb 5, 2026
Merged

gh-74955: Document that __all__ must contain strings in normalization form NFKC#144504
serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka:docs-all-non-ascii

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 5, 2026 •
edited by github-actions bot
Loading

@serhiy-storchaka serhiy-storchaka added the docs Documentation in the Doc dir label Feb 5, 2026
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 5, 2026
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Feb 5, 2026
@bedevere-app bedevere-app bot mentioned this pull request Feb 5, 2026
Closed
vstinner
vstinner approved these changes Feb 5, 2026
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit c81e184 into python:main Feb 5, 2026
33 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Feb 5, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 5, 2026

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2026
@serhiy-storchaka @miss-islington
pythongh-74955: Document that __all__ must contain strings in normali…
2bdf674 
…zation form NFKC (pythonGH-144504)

(cherry picked from commit c81e1843d4bc0a51cf4f77d19b5ac4e49f714a0d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka deleted the docs-all-non-ascii branch February 5, 2026 18:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2026
@serhiy-storchaka @miss-islington
pythongh-74955: Document that __all__ must contain strings in normali…
08685eb 
…zation form NFKC (pythonGH-144504)

(cherry picked from commit c81e1843d4bc0a51cf4f77d19b5ac4e49f714a0d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 5, 2026

GH-144519 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 5, 2026
@bedevere-app
Copy link

bedevere-app bot commented Feb 5, 2026

GH-144520 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 5, 2026
serhiy-storchaka added a commit that referenced this pull request Feb 5, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-74955: Document that __all__ must contain strings in normal…
6614a3c 
…ization form NFKC (GH-144504) (GH-144519)

(cherry picked from commit c81e184)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@skirpichev skirpichev skirpichev approved these changes

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @vstinner @skirpichev