Skip to content

Conversation

@hyperkai
Copy link
Contributor

@hyperkai hyperkai commented Jan 31, 2026

Fix: #20683

I changed arguments to parameters in the error messages of these constants below and I also changed some names of constants:

ARGUMENT_TYPE_EXPECTED       => PARAM_TYPE_EXPECTED
MISSING_OR_INVALID_SELF_TYPE
ELLIPSIS_WITH_OTHER_TYPEARGS => ELLIPSIS_WITH_OTHER_TYPEPARAMS
TYPE_SIGNATURE_TOO_MANY_ARGS => TYPE_SIGNATURE_TOO_MANY_PARAMS
TYPE_SIGNATURE_TOO_FEW_ARGS  => TYPE_SIGNATURE_TOO_FEW_PARAMS

@github-actions

This comment has been minimized.

@hyperkai hyperkai changed the title Update arguments to parameters related to ARGUMENT_TYPE_EXPECTED Update arguments to parameters related to ARGUMENT_TYPE_EXPECTED and MISSING_OR_INVALID_SELF_TYPE Feb 1, 2026
# Self-type
MISSING_OR_INVALID_SELF_TYPE: Final = ErrorMessage(
"Self argument missing for a non-static method (or an invalid type for self)"
"self parameter missing for a non-static method (or an invalid type for self)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed Self to self which is actually used as a parameter because It's more understandable:

class Cls:  # ↓↓↓↓
   def method(self) -> None: ...

@github-actions

This comment has been minimized.

@hyperkai hyperkai changed the title Update arguments to parameters related to ARGUMENT_TYPE_EXPECTED and MISSING_OR_INVALID_SELF_TYPE Update arguments to parameters (Additional) 1 Feb 1, 2026
@hyperkai hyperkai changed the title Update arguments to parameters (Additional) 1 Update arguments to parameters (Additional) [1] Feb 1, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Diff from mypy_primer, showing the effect of this PR on open source code:

colour (https://github.com/colour-science/colour)
- colour/characterisation/aces_it.py:975: error: Ellipses cannot accompany other argument types in function type signature  [syntax]
+ colour/characterisation/aces_it.py:975: error: Ellipses cannot accompany other parameter types in function type signature  [syntax]

cki-lib (https://gitlab.com/cki-project/cki-lib)
- cki_lib/metrics/server.py:8: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/metrics/server.py:8: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/s3bucket.py:18: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/s3bucket.py:18: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/kcidb/validate.py:49: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/kcidb/validate.py:49: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/kcidb/validate.py:137: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/kcidb/validate.py:137: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/cki_pipeline.py:199: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/cki_pipeline.py:199: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/messagequeue.py:269: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/messagequeue.py:269: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/messagequeue.py:338: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/messagequeue.py:338: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/messagequeue.py:389: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/messagequeue.py:389: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/messagequeue.py:447: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/messagequeue.py:447: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- tests/kcidb/test_checks.py:193: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ tests/kcidb/test_checks.py:193: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- tests/kcidb/test_checks.py:207: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ tests/kcidb/test_checks.py:207: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

steam.py (https://github.com/Gobot1234/steam.py)
- steam/_const.py:73: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/_const.py:73: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- steam/utils.py:167: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/utils.py:167: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- steam/utils.py:173: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/utils.py:173: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- steam/utils.py:221: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/utils.py:221: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- steam/utils.py:227: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/utils.py:227: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

discord.py (https://github.com/Rapptz/discord.py)
- discord/client.py:1887: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+ discord/client.py:1887: error: self parameter missing for a non-static method (or an invalid type for self)  [misc]
- discord/client.py:1897: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+ discord/client.py:1897: error: self parameter missing for a non-static method (or an invalid type for self)  [misc]

pyodide (https://github.com/pyodide/pyodide)
- pyodide-build/pyodide_build/common.py:298: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:298: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/common.py:440: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:440: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/common.py:452: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:452: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/common.py:463: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:463: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/recipe/skeleton.py:237: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/skeleton.py:237: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/recipe/skeleton.py:246: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/skeleton.py:246: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/tests/test_cli_xbuildenv.py:29: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/tests/test_cli_xbuildenv.py:29: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/recipe/builder.py:781: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/builder.py:781: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:133: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:133: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:161: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:161: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/tests/test_cli.py:299: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/tests/test_cli.py:299: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

pandera (https://github.com/pandera-dev/pandera)
- tests/pandas/test_model.py:47: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+ tests/pandas/test_model.py:47: error: self parameter missing for a non-static method (or an invalid type for self)  [misc]
- tests/pandas/test_model.py:52: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+ tests/pandas/test_model.py:52: error: self parameter missing for a non-static method (or an invalid type for self)  [misc]

artigraph (https://github.com/artigraph/artigraph)
- src/arti/internal/models.py:146: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ src/arti/internal/models.py:146: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- src/arti/internal/models.py:150: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ src/arti/internal/models.py:150: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

pyppeteer (https://github.com/pyppeteer/pyppeteer)
- pyppeteer/launcher.py:222: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyppeteer/launcher.py:222: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant