-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Update arguments to parameters (Additional) [1]
#20711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hyperkai
wants to merge
30
commits into
python:master
Choose a base branch
from
hyperkai:hyperkai-patch-12
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+61
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
arguments to parameters related to ARGUMENT_TYPE_EXPECTEDarguments to parameters related to ARGUMENT_TYPE_EXPECTED and MISSING_OR_INVALID_SELF_TYPE
hyperkai
commented
Feb 1, 2026
| # Self-type | ||
| MISSING_OR_INVALID_SELF_TYPE: Final = ErrorMessage( | ||
| "Self argument missing for a non-static method (or an invalid type for self)" | ||
| "self parameter missing for a non-static method (or an invalid type for self)" |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also changed Self to self which is actually used as a parameter because It's more understandable:
class Cls: # ↓↓↓↓
def method(self) -> None: ...
This comment has been minimized.
This comment has been minimized.
arguments to parameters related to ARGUMENT_TYPE_EXPECTED and MISSING_OR_INVALID_SELF_TYPEarguments to parameters (Additional) 1
arguments to parameters (Additional) 1arguments to parameters (Additional) [1]
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: colour (https://github.com/colour-science/colour)
- colour/characterisation/aces_it.py:975: error: Ellipses cannot accompany other argument types in function type signature [syntax]
+ colour/characterisation/aces_it.py:975: error: Ellipses cannot accompany other parameter types in function type signature [syntax]
cki-lib (https://gitlab.com/cki-project/cki-lib)
- cki_lib/metrics/server.py:8: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/metrics/server.py:8: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- cki_lib/s3bucket.py:18: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/s3bucket.py:18: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- cki_lib/kcidb/validate.py:49: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/kcidb/validate.py:49: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- cki_lib/kcidb/validate.py:137: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/kcidb/validate.py:137: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- cki_lib/cki_pipeline.py:199: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/cki_pipeline.py:199: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- cki_lib/messagequeue.py:269: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/messagequeue.py:269: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- cki_lib/messagequeue.py:338: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/messagequeue.py:338: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- cki_lib/messagequeue.py:389: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/messagequeue.py:389: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- cki_lib/messagequeue.py:447: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ cki_lib/messagequeue.py:447: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- tests/kcidb/test_checks.py:193: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ tests/kcidb/test_checks.py:193: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- tests/kcidb/test_checks.py:207: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ tests/kcidb/test_checks.py:207: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
steam.py (https://github.com/Gobot1234/steam.py)
- steam/_const.py:73: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ steam/_const.py:73: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- steam/utils.py:167: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ steam/utils.py:167: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- steam/utils.py:173: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ steam/utils.py:173: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- steam/utils.py:221: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ steam/utils.py:221: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- steam/utils.py:227: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ steam/utils.py:227: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
discord.py (https://github.com/Rapptz/discord.py)
- discord/client.py:1887: error: Self argument missing for a non-static method (or an invalid type for self) [misc]
+ discord/client.py:1887: error: self parameter missing for a non-static method (or an invalid type for self) [misc]
- discord/client.py:1897: error: Self argument missing for a non-static method (or an invalid type for self) [misc]
+ discord/client.py:1897: error: self parameter missing for a non-static method (or an invalid type for self) [misc]
pyodide (https://github.com/pyodide/pyodide)
- pyodide-build/pyodide_build/common.py:298: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:298: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/common.py:440: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:440: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/common.py:452: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:452: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/common.py:463: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:463: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/recipe/skeleton.py:237: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/skeleton.py:237: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/recipe/skeleton.py:246: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/skeleton.py:246: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/tests/test_cli_xbuildenv.py:29: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/tests/test_cli_xbuildenv.py:29: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/recipe/builder.py:781: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/builder.py:781: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:133: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:133: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:161: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:161: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- pyodide-build/pyodide_build/tests/test_cli.py:299: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyodide-build/pyodide_build/tests/test_cli.py:299: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
pandera (https://github.com/pandera-dev/pandera)
- tests/pandas/test_model.py:47: error: Self argument missing for a non-static method (or an invalid type for self) [misc]
+ tests/pandas/test_model.py:47: error: self parameter missing for a non-static method (or an invalid type for self) [misc]
- tests/pandas/test_model.py:52: error: Self argument missing for a non-static method (or an invalid type for self) [misc]
+ tests/pandas/test_model.py:52: error: self parameter missing for a non-static method (or an invalid type for self) [misc]
artigraph (https://github.com/artigraph/artigraph)
- src/arti/internal/models.py:146: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ src/arti/internal/models.py:146: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
- src/arti/internal/models.py:150: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ src/arti/internal/models.py:150: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
pyppeteer (https://github.com/pyppeteer/pyppeteer)
- pyppeteer/launcher.py:222: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ pyppeteer/launcher.py:222: error: Function is missing a type annotation for one or more parameters [no-untyped-def]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #20683
I changed
argumentstoparametersin the error messages of these constants below and I also changed some names of constants: